starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3863] [MERGED] Fixes #2113: NAPALM driver settings #12666

New Issue
Closed
opened 2025-12-29 22:22:56 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3863
Author: @hSaria
Created: 1/8/2020
Status: ✅ Merged
Merged: 1/9/2020
Merged by: @jeremystretch

Base: develop ← Head: 2113-napalm-settings

📝 Commits (6)

  • dc475f4 Fixes #2113: Adjust NAPALM settings with headers
  • ce8d470 Added NAPALM documentation
  • 98a66f7 NAPALM settings changelog
  • f49467b Corrected optional arg assignment
  • 60e4812 Merge branch 'develop' into 2113-napalm-settings
  • 9d085ad Changed NAPALM- prefix to X-NAPALM-

📊 Changes

4 files changed (+85 additions, -2 deletions)

View changed files

➕ docs/additional-features/napalm.md (+65 -0)
📝 docs/release-notes/version-2.6.md (+1 -0)
📝 mkdocs.yml (+1 -0)
📝 netbox/dcim/api/views.py (+18 -2)

📄 Description

Fixes: #2113

  • Allow the username and password for NAPALM to be overridden for an API call.
  • Expose NAPALM's optional_args using headers prefixes with NAPALM-. Because they can contain sensitive information like secret, I've opted to use headers.
  • Documented how NetBox works with NAPALM and other odd and ends.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3863 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/8/2020 **Status:** ✅ Merged **Merged:** 1/9/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `2113-napalm-settings` --- ### 📝 Commits (6) - [`dc475f4`](https://github.com/netbox-community/netbox/commit/dc475f4755a6ab8d77e60de40e9142c795581317) Fixes #2113: Adjust NAPALM settings with headers - [`ce8d470`](https://github.com/netbox-community/netbox/commit/ce8d47086033cee2e707bb27f769eb9d6d1dd36e) Added NAPALM documentation - [`98a66f7`](https://github.com/netbox-community/netbox/commit/98a66f7fbe77ef849ce0b27bb9dca80a7edc36c5) NAPALM settings changelog - [`f49467b`](https://github.com/netbox-community/netbox/commit/f49467bcb5370f6bd39cbc786328874981c88c71) Corrected optional arg assignment - [`60e4812`](https://github.com/netbox-community/netbox/commit/60e4812b323c745b48a3753c0d09af341bf24c80) Merge branch 'develop' into 2113-napalm-settings - [`9d085ad`](https://github.com/netbox-community/netbox/commit/9d085ad83a26aa90eeed4c36c123171bf6ae0c80) Changed `NAPALM-` prefix to `X-NAPALM-` ### 📊 Changes **4 files changed** (+85 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `docs/additional-features/napalm.md` (+65 -0) 📝 `docs/release-notes/version-2.6.md` (+1 -0) 📝 `mkdocs.yml` (+1 -0) 📝 `netbox/dcim/api/views.py` (+18 -2) </details> ### 📄 Description ### Fixes: #2113 * Allow the username and password for NAPALM to be overridden for an API call. * Expose NAPALM's `optional_args` using headers prefixes with `NAPALM-`. Because they can contain sensitive information like `secret`, I've opted to use headers. * Documented how NetBox works with NAPALM and other odd and ends. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:56 +01:00
adam closed this issue 2025-12-29 22:22:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12666
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?