Compare commits

..

2 Commits

Author SHA1 Message Date
bctiemann
e65a5e16f1 Merge branch 'feature' into 21331-deprecate-querystring-tag 2026-02-19 12:48:14 -05:00
Brian Tiemann
dacb7d7f61 Emit deprecation warning on use of querystring template tag 2026-02-18 15:41:38 -05:00
3 changed files with 17 additions and 20 deletions

View File

@@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2026-02-20 05:22+0000\n"
"POT-Creation-Date: 2026-02-19 05:26+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -472,7 +472,7 @@ msgstr ""
#: netbox/dcim/tables/devicetypes.py:214 netbox/dcim/tables/devicetypes.py:255
#: netbox/dcim/tables/devicetypes.py:274 netbox/dcim/tables/racks.py:30
#: netbox/extras/forms/bulk_edit.py:306 netbox/extras/tables/tables.py:552
#: netbox/netbox/ui/attrs.py:192 netbox/templates/circuits/circuittype.html:30
#: netbox/netbox/ui/attrs.py:190 netbox/templates/circuits/circuittype.html:30
#: netbox/templates/circuits/virtualcircuittype.html:30
#: netbox/templates/dcim/cable.html:44 netbox/templates/dcim/devicerole.html:38
#: netbox/templates/dcim/frontport.html:40
@@ -2129,7 +2129,7 @@ msgstr ""
msgid "Warning"
msgstr ""
#: netbox/core/constants.py:33 netbox/netbox/tables/columns.py:589
#: netbox/core/constants.py:33 netbox/netbox/tables/columns.py:590
#: netbox/templates/core/job.html:26
msgid "Error"
msgstr ""
@@ -4249,7 +4249,7 @@ msgstr ""
#: netbox/extras/forms/model_forms.py:691
#: netbox/extras/forms/model_forms.py:743 netbox/extras/ui/panels.py:69
#: netbox/netbox/forms/bulk_import.py:27 netbox/netbox/forms/mixins.py:131
#: netbox/netbox/tables/columns.py:495
#: netbox/netbox/tables/columns.py:496
#: netbox/templates/circuits/inc/circuit_termination.html:29
#: netbox/templates/generic/bulk_edit.html:78
#: netbox/templates/inc/panels/tags.html:5
@@ -12782,15 +12782,15 @@ msgstr ""
msgid "Chinese"
msgstr ""
#: netbox/netbox/tables/columns.py:183
#: netbox/netbox/tables/columns.py:184
msgid "Select all"
msgstr ""
#: netbox/netbox/tables/columns.py:196
#: netbox/netbox/tables/columns.py:197
msgid "Toggle all"
msgstr ""
#: netbox/netbox/tables/columns.py:316
#: netbox/netbox/tables/columns.py:317
#: netbox/templates/inc/table_controls_htmx.html:35
msgid "Toggle Dropdown"
msgstr ""
@@ -12817,13 +12817,7 @@ msgstr ""
msgid "Copy"
msgstr ""
#: netbox/netbox/ui/attrs.py:211
#, python-brace-format
msgid ""
"Invalid decoding option: {decoding}! Must be one of {image_decoding_choices}"
msgstr ""
#: netbox/netbox/ui/attrs.py:316
#: netbox/netbox/ui/attrs.py:286
msgid "GPS coordinates"
msgstr ""
@@ -16641,12 +16635,12 @@ msgstr ""
msgid "Required column header \"{header}\" not found."
msgstr ""
#: netbox/utilities/forms/widgets/apiselect.py:132
#: netbox/utilities/forms/widgets/apiselect.py:133
#, python-brace-format
msgid "Missing required value for dynamic query param: '{dynamic_params}'"
msgstr ""
#: netbox/utilities/forms/widgets/apiselect.py:149
#: netbox/utilities/forms/widgets/apiselect.py:150
#, python-brace-format
msgid "Missing required value for static query param: '{static_params}'"
msgstr ""

View File

@@ -1,4 +1,5 @@
import json
import logging
from typing import Any
from urllib.parse import quote
@@ -13,6 +14,8 @@ from utilities.forms import TableConfigForm, get_selected_values
from utilities.forms.mixins import FORM_FIELD_LOOKUPS
from utilities.views import get_action_url, get_viewname
logger = logging.getLogger("netbox.utilities.templatetags.helpers")
__all__ = (
'action_url',
'applied_filters',
@@ -363,6 +366,10 @@ def querystring(request, **kwargs):
"""
Append or update the page number in a querystring.
"""
logger.warning(
'The querystring template tag is deprecated and will be removed in a future release. Use '
'the built-in Django querystring tag instead.',
)
querydict = request.GET.copy()
for k, v in kwargs.items():
if v is not None:

View File

@@ -30,10 +30,6 @@ respect-gitignore = true
target-version = "py312"
[lint]
# Pin the effective default rule set used with `preview = true` to match Ruff 0.15.1.
# Ruff 0.15.2 changed the preview defaults, see https://github.com/astral-sh/ruff/releases/tag/0.15.2
# Keeping this explicit makes ruff deterministic.
select = ["E4", "E7", "E9", "F"]
extend-select = [
"E1", # pycodestyle errors: indentation-related (e.g., unexpected/missing indent)
"E2", # pycodestyle errors: whitespace-related (e.g., missing whitespace, extra spaces)