starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-03-31 14:43:36 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Align ManagedFileForm validation with API serializer rules

Browse Source 
Add the missing checks to ManagedFileForm.clean():
- upload_file + data_source is rejected (matches API)
- data_source without data_file is rejected with a specific message
- Update the 'nothing provided' error to mention data source + data file

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Arthur
2026-03-30 15:37:58 -07:00
parent f9af8e2068
commit f0ac7c3bd2
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
netbox/core/forms/model_forms.py
View File

@@ -107,10 +107,18 @@ class ManagedFileForm(SyncedDataMixin, NetBoxModelForm):
def clean(self):
super().clean()
if self.cleaned_data.get('upload_file') and self.cleaned_data.get('data_file'):
upload_file = self.cleaned_data.get('upload_file')
data_source = self.cleaned_data.get('data_source')
data_file = self.cleaned_data.get('data_file')
if upload_file and data_file:
raise forms.ValidationError(_("Cannot upload a file and sync from an existing file"))
if not self.cleaned_data.get('upload_file') and not self.cleaned_data.get('data_file'):
raise forms.ValidationError(_("Must upload a file or select a data file to sync"))
if upload_file and data_source:
raise forms.ValidationError(_("Cannot upload a file and sync from a data source."))
if data_source and not data_file:
raise forms.ValidationError(_("A data file must be specified when syncing from a data source."))
if not upload_file and not data_file:
raise forms.ValidationError(_("Must upload a file or select a data source and data file to sync."))
return self.cleaned_data