Raise a validation error if remove_tags is specified when creating an object

This commit is contained in:
Jeremy Stretch
2026-03-31 16:38:15 -04:00
parent 95011821bb
commit 8bc691099c
2 changed files with 26 additions and 0 deletions

View File

@@ -368,6 +368,27 @@ class SiteTest(APIViewTestCases.APIViewTestCase):
tag_names = sorted(site.tags.values_list('name', flat=True))
self.assertEqual(tag_names, ['Alpha', 'Bravo'])
def test_create_with_remove_tags_error(self):
"""
Using remove_tags when creating a new object should raise a validation error.
"""
Tag.objects.bulk_create((
Tag(name='Alpha', slug='alpha'),
))
obj_perm = ObjectPermission(name='Test permission', actions=['add'])
obj_perm.save()
obj_perm.users.add(self.user)
obj_perm.object_types.add(ObjectType.objects.get_for_model(self.model))
data = {
'name': 'Site 10',
'slug': 'site-10',
'remove_tags': [{'name': 'Alpha'}],
}
response = self.client.post(self._get_list_url(), data, format='json', **self.header)
self.assertHttpStatus(response, status.HTTP_400_BAD_REQUEST)
class LocationTest(APIViewTestCases.APIViewTestCase):
model = Location

View File

@@ -55,6 +55,11 @@ class TaggableModelSerializer(serializers.Serializer):
'tags': 'Cannot specify "tags" together with "add_tags" or "remove_tags".'
})
if self.instance is None and data.get('remove_tags'):
raise serializers.ValidationError({
'remove_tags': 'Cannot use "remove_tags" when creating a new object.'
})
# Pop add_tags/remove_tags before calling super() to prevent them from being passed
# to the model constructor during ValidatedModelSerializer validation
add_tags = data.pop('add_tags', None)