starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-03-31 14:43:36 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

destroy() deletes ScriptModule, not Script

Browse Source 
DELETE /api/extras/scripts/<pk>/ now deletes the entire ScriptModule
(matching the UI's delete view), including modules with no Script
children (e.g. sync hasn't run yet). Permission check updated to
delete_scriptmodule. The queryset restriction for destroy is removed
since the module is deleted via script.module, not super().destroy().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Arthur
2026-03-30 15:53:35 -07:00
parent a128b7de55
commit 4dc6564a17
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
netbox/extras/api/views.py
View File

@@ -284,12 +284,7 @@ class ScriptViewSet(ModelViewSet):
# Restrict the view's QuerySet to allow only the permitted objects
if request.user.is_authenticated and self.action != 'create':
if self.action == 'destroy':
perm_action = 'delete'
elif request.method == 'POST':
perm_action = 'run'
else:
perm_action = 'view'
perm_action = 'run' if request.method == 'POST' else 'view'
self.queryset = self.queryset.restrict(request.user, perm_action)
def create(self, request, *args, **kwargs):
@@ -320,9 +315,11 @@ class ScriptViewSet(ModelViewSet):
raise MethodNotAllowed(request.method)
def destroy(self, request, *args, **kwargs):
if not request.user.has_perm('extras.delete_script'):
raise PermissionDenied(_("This user does not have permission to delete scripts."))
return super().destroy(request, *args, **kwargs)
if not request.user.has_perm('extras.delete_scriptmodule'):
raise PermissionDenied(_("This user does not have permission to delete script modules."))
script = self._get_script(kwargs[self.lookup_field])
script.module.delete()
return Response(status=status.HTTP_204_NO_CONTENT)
def _get_script(self, pk):
# If pk is numeric, retrieve script by ID