mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-16 13:51:19 +01:00
Switch the 40 Window::focus(mouse_follows)? call sites in process_event, process_command, workspace, window_manager, focus_manager and the stackbar click to backend().focus(WindowId::from_hwnd(..), mouse_follows). WindowsBackend::focus runs Window::focus, so the deferral while a window slides in, the already-foreground shortcut and the cursor centring are unchanged. animation/transition.rs:534 stays on Window::focus (it is the code Window::focus defers to). docs/dev/backend-switch.md records what is switched. BEHAVIOUR: a dead window now fails early with Error::WindowGone (before: the Win32 error from raise_and_focus_window) and a failed focus of a window that died meanwhile reports WindowGone; every caller uses ? or ignores the result. e2e gate needed: commands, focus, focus_follows_mouse, stacking, workspaces, lifecycle. Verified: Windows clippy -D warnings via tools/fast-check PASS; e2e not run.
18 lines
1.6 KiB
Markdown
18 lines
1.6 KiB
Markdown
# Windows: which call sites go through `backend()`
|
|
|
|
Step 8 of the unified-binaries plan. `komorebi::windows_backend::backend()` returns the shared
|
|
`komorebi_backend::Backend` (a stateless `WindowsBackend` over `WindowsApi` and `Window`). The daemon
|
|
switches one cluster at a time; each switch is its own revision marked BEHAVIOUR.
|
|
|
|
What every switch changes, for the Windows daemon: `WindowsBackend` first asks `IsWindow` and fails
|
|
with `Error::WindowGone` for a dead window, and a failure of a window that died meanwhile is reported
|
|
as `WindowGone` (the message text changes: it was the Win32 error). Call sites use `?` or ignore the
|
|
result, none inspects the error.
|
|
|
|
| Cluster | Operation | Status | Sites | Left on `Window`/`WindowsApi`, and why | e2e needed |
|
|
|---|---|---|---|---|---|
|
|
| focus | `focus(id, mouse_follows)` | switched | process_event (4), process_command (3), workspace (7), window_manager (24), focus_manager, stackbar | `animation/transition.rs:534` calls `Window::focus` from inside the slide-in code that `Window::focus` itself defers to (it would recurse through the backend for no gain) | commands, focus, focus_follows_mouse, stacking, workspaces, lifecycle |
|
|
| frame / position | `set_rect`, `window_rect` | not switched | | `Window::set_position` has the `top` flag, animation/slide-in/live-resize guards that the backend `set_rect` (always `top = false`) cannot carry | |
|
|
| hide / show | `hide`, `restore`, `minimize`, `unminimize`, `raise`, `close` | not switched | | | |
|
|
| queries | `window`, `foreground_window`, `cursor_pos`, `monitors`, `monitor_from_point` | not switched | | | |
|