mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[BUG]: Komrebi Bar configurations not being loaded correctly #504
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @H7ioo on GitHub (Oct 22, 2024).
Summary
Komorebi bar's few configurations don't apply correctly on the
komorebic start --whkd --barcommandBug video demo
Version Information
OS Name: Microsoft Windows 11 Home Single Language
OS Version: 10.0.22631 N/A Build 22631
komorebic 0.1.29
tag:v0.1.29
commit_hash:818ac340
build_time:2024-09-28 01:48:31 +00:00
build_env:rustc 1.81.0 (eeb90cda1 2024-09-04),stable-x86_64-pc-windows-msvc
Komorebi Configuration
Komorebi.json
Komorebi.bar.json
Output of komorebic check
@LGUG2Z commented on GitHub (Oct 22, 2024):
Hello and thanks for the report. There are currently a bunch of fixes for various bar issues on the latest nightly release.
To avoid duplicating effort please first confirm if you can reproduce these issues on the nightly release.
@H7ioo commented on GitHub (Oct 22, 2024):
Sure!
Summary
Steps Taken
Got the following error:
Your bar configuration file contains some options that have been renamed or deprecated "viewport" is now "position"Updated "viewport" to "position" and made
y:20instead ofy: 10because the old (y:10) cut the bar in half.Schema.bar.json
Thanks for the awesome project by the way.
@xidsyed commented on GitHub (Nov 10, 2024):
I have been facing the same problem. I have some position configurations specified in my Json file that don't get applied unless I reopen vs code and press
ctrl + sto re-save thekomkorebi-bar.jsonfile to have the bar update to the correct position.do the configurations not get loaded when the bar gets launched?
@H7ioo commented on GitHub (Nov 10, 2024):
Which version are you running?
@xidsyed commented on GitHub (Nov 10, 2024):
@xidsyed commented on GitHub (Nov 11, 2024):
it's interesting that everything else gets loaded correctly on bar start except for the position configurations, in my case:
probably a little bug somehwere
@LGUG2Z take a look at this when u can pretty please 🥹
@modefang commented on GitHub (Dec 9, 2024):
I have the same issues
komorebi.json
@alex-ds13 commented on GitHub (Jan 8, 2025):
This should be fixed now on master.
@LGUG2Z I didn't notice this issue before, so didn't link it on my PR but it probably can be closed as well since it seems to be the same thing that the PR #1219 fixed.