starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1136] [MERGED] fix(wm): focus maximized windows when moving focus across monitors #1219

New Issue
Closed
opened 2026-01-05 14:54:30 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1136
Author: @alex-ds13
Created: 11/21/2024
Status: ✅ Merged
Merged: 11/21/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/change_monitor_focus_with_maximized

📝 Commits (2)

  • 0c3bd79 fix(wm): focus maximized windows when moving focus across monitors
  • bf1acab fix(wm): disallow focusing other windows when there is a maximized_window

📊 Changes

1 file changed (+20 additions, -9 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+20 -9)

📄 Description

There was an issue where if you changed focus across monitors and the target monitor had a maximized window it would focus one of the containers beneath it instead. And if there were no containers it wouldn't focus anything, but instead keep focus on the previous monitor. This commit fixes that issue.

This was first brought up on discord here. The user has already tested this fix and it is working fine! Now is just a matter of deciding if we keep that code that centers the mouse on the screen, no matter what the value of "mff" is?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1136 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 11/21/2024 **Status:** ✅ Merged **Merged:** 11/21/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/change_monitor_focus_with_maximized` --- ### 📝 Commits (2) - [`0c3bd79`](https://github.com/LGUG2Z/komorebi/commit/0c3bd7941454751a1986b6f21c43a23e6e6fd0ac) fix(wm): focus maximized windows when moving focus across monitors - [`bf1acab`](https://github.com/LGUG2Z/komorebi/commit/bf1acab5e4a731725a047c5acd97407ab0a4d5bf) fix(wm): disallow focusing other windows when there is a maximized_window ### 📊 Changes **1 file changed** (+20 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+20 -9) </details> ### 📄 Description There was an issue where if you changed focus across monitors and the target monitor had a maximized window it would focus one of the containers beneath it instead. And if there were no containers it wouldn't focus anything, but instead keep focus on the previous monitor. This commit fixes that issue. This was first brought up on discord [here](https://discord.com/channels/898554690126630914/1308841644853952543/1308841644853952543). The user has already tested this fix and it is working fine! Now is just a matter of deciding if we keep that code that centers the mouse on the screen, no matter what the value of "mff" is? <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:30 +01:00
adam closed this issue 2026-01-05 14:54:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1219
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?