[PR #1377] [MERGED] fix: disabled borders remove width + offset #1367

New Issue

2026-01-05T14:55:02+01:00

adam commented

2026-01-05 14:55:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1377
Author: @alex-ds13
Created: 3/26/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/disabled-borders-remove-width

📝 Commits (2)

da50ffe fix(docs): borders are enabled by default
0f5a36e fix(wm): remove border width/offset when disabled

📊 Changes

5 files changed (+60 additions, -42 deletions)

View changed files

📝 docs/common-workflows/remove-gaps.md (+1 -5)
📝 komorebi/src/monitor.rs (+48 -16)
📝 komorebi/src/static_config.rs (+2 -5)
📝 komorebi/src/workspace.rs (+8 -15)
📝 schema.json (+1 -1)

📄 Description

Fix wrong docs info, borders are enabled by default but the docs said they were disabled by default.
Disabling the borders now also ignores the border_width and border_offset. Previously you would have to set them to 0 after disabling the borders or they would still count for the containers gap. Now if the borders are disabled they are no longer taken into account.
Setting "border": false and then removing that line completely will re-enable the borders as it should since the default is to have them enabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1377 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/26/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/disabled-borders-remove-width` --- ### 📝 Commits (2) - [`da50ffe`](https://github.com/LGUG2Z/komorebi/commit/da50ffe38d9ba802487d37e5f1c53fd6444661a4) fix(docs): borders are enabled by default - [`0f5a36e`](https://github.com/LGUG2Z/komorebi/commit/0f5a36e01e0e09ba8dba1d8d684c56d663e4c3b6) fix(wm): remove border width/offset when disabled ### 📊 Changes **5 files changed** (+60 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `docs/common-workflows/remove-gaps.md` (+1 -5) 📝 `komorebi/src/monitor.rs` (+48 -16) 📝 `komorebi/src/static_config.rs` (+2 -5) 📝 `komorebi/src/workspace.rs` (+8 -15) 📝 `schema.json` (+1 -1) </details> ### 📄 Description - Fix wrong docs info, borders are enabled by default but the docs said they were disabled by default. - Disabling the borders now also ignores the `border_width` and `border_offset`. Previously you would have to set them to 0 after disabling the borders or they would still count for the containers gap. Now if the borders are disabled they are no longer taken into account. - Setting `"border": false` and then removing that line completely will re-enable the borders as it should since the default is to have them enabled.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:55:02 +01:00

adam closed this issue

2026-01-05 14:55:03 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1367