starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1396] [MERGED] feature/custom themes #1377

New Issue
Closed
opened 2026-01-05 14:55:04 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1396
Author: @alex-ds13
Created: 4/2/2025
Status: ✅ Merged
Merged: 4/4/2025
Merged by: @LGUG2Z

Base: master ← Head: feature/custom-themes

📝 Commits (4)

  • 8c9c3ca fix(wm): skip serde on WorkspaceGlobals
  • 9edc642 feat(wm): apply wallpapers per monitor
  • 2ba2a77 fix(wm): properly update border colors
  • 7203325 feat(wm): allow setting wallpaper per monitor

📊 Changes

10 files changed (+256 additions, -109 deletions)

View changed files

📝 komorebi/src/border_manager/border.rs (+19 -21)
📝 komorebi/src/border_manager/mod.rs (+96 -54)
📝 komorebi/src/monitor.rs (+8 -1)
📝 komorebi/src/monitor_reconciliator/mod.rs (+1 -0)
📝 komorebi/src/process_command.rs (+42 -23)
📝 komorebi/src/static_config.rs (+7 -0)
📝 komorebi/src/theme_manager.rs (+1 -1)
📝 komorebi/src/window_manager.rs (+33 -0)
📝 komorebi/src/windows_api.rs (+37 -2)
📝 komorebi/src/workspace.rs (+12 -7)

📄 Description

  • Apply wallpaper only on the workspace monitor
  • Properly update border colors
  • Add option for setting wallpaper per-monitor
  • Read the current wallpaper on each monitor on startup and set that monitor's wallpaper to a new Wallpaper with that path and generate_theme set to false
    • This however has the downside that the generate_theme behaves as if it was false by default, since if you don't set it on the workspace nor on the monitor it will use the default one from the start which is false

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1396 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 4/2/2025 **Status:** ✅ Merged **Merged:** 4/4/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `feature/custom-themes` --- ### 📝 Commits (4) - [`8c9c3ca`](https://github.com/LGUG2Z/komorebi/commit/8c9c3ca7da4b24c96054089aa6ce37d21ceca99c) fix(wm): skip serde on `WorkspaceGlobals` - [`9edc642`](https://github.com/LGUG2Z/komorebi/commit/9edc642d83ca3232a34c75801aab4c6188ddbc45) feat(wm): apply wallpapers per monitor - [`2ba2a77`](https://github.com/LGUG2Z/komorebi/commit/2ba2a77e44a09bf7cc584d204df17d018bd71c9c) fix(wm): properly update border colors - [`7203325`](https://github.com/LGUG2Z/komorebi/commit/72033254becacff94030289f45aaaad154dc9723) feat(wm): allow setting wallpaper per monitor ### 📊 Changes **10 files changed** (+256 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/border_manager/border.rs` (+19 -21) 📝 `komorebi/src/border_manager/mod.rs` (+96 -54) 📝 `komorebi/src/monitor.rs` (+8 -1) 📝 `komorebi/src/monitor_reconciliator/mod.rs` (+1 -0) 📝 `komorebi/src/process_command.rs` (+42 -23) 📝 `komorebi/src/static_config.rs` (+7 -0) 📝 `komorebi/src/theme_manager.rs` (+1 -1) 📝 `komorebi/src/window_manager.rs` (+33 -0) 📝 `komorebi/src/windows_api.rs` (+37 -2) 📝 `komorebi/src/workspace.rs` (+12 -7) </details> ### 📄 Description - Apply wallpaper only on the workspace monitor - Properly update border colors - Add option for setting wallpaper per-monitor - Read the current wallpaper on each monitor on startup and set that monitor's `wallpaper` to a new `Wallpaper` with that path and `generate_theme` set to `false` - This however has the downside that the `generate_theme` behaves as if it was `false` by default, since if you don't set it on the workspace nor on the monitor it will use the default one from the start which is `false` <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:04 +01:00
adam closed this issue 2026-01-05 14:55:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1377
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?