starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1338] [MERGED] fix(wm): correct float window move/resize #1338

New Issue
Closed
opened 2026-01-05 14:54:56 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1338
Author: @alex-ds13
Created: 3/12/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/floating-move-on-secondary-monitors

📝 Commits (1)

  • ac2f139 fix(wm): correct float window move/resize

📊 Changes

1 file changed (+22 additions, -8 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+22 -8)

📄 Description

This commit fixes an issue where the move/resize functions for floating windows weren't properly taking into account the coordinates of secondary monitors and were only working correctly on the main monitor where top/left was 0/0.

This issue was first brought up by a user on Discord

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1338 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/12/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/floating-move-on-secondary-monitors` --- ### 📝 Commits (1) - [`ac2f139`](https://github.com/LGUG2Z/komorebi/commit/ac2f139366cb4c0f1010d47b1e0fa23b5888b4c5) fix(wm): correct float window move/resize ### 📊 Changes **1 file changed** (+22 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+22 -8) </details> ### 📄 Description This commit fixes an issue where the move/resize functions for floating windows weren't properly taking into account the coordinates of secondary monitors and were only working correctly on the main monitor where top/left was 0/0. This issue was first brought up by a user on [Discord](https://discord.com/channels/898554690126630914/1348547975055409152) <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:56 +01:00
adam closed this issue 2026-01-05 14:54:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?