[PR #1293] [MERGED] feat(bar): added option to show all icons on the komorebi workspace #1305

New Issue

2026-01-05T14:54:49+01:00

adam commented

2026-01-05 14:54:49 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1293
Author: @CtByte
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @LGUG2Z

Base: master ← Head: all_icons

📝 Commits (1)

d140544 feat(bar): added option to show all icons on the komorebi workspace

📊 Changes

4 files changed (+247 additions, -86 deletions)

View changed files

📝 komorebi-bar/src/config.rs (+9 -0)
📝 komorebi-bar/src/komorebi.rs (+69 -32)
📝 komorebi-bar/src/render.rs (+13 -0)
📝 schema.bar.json (+156 -54)

📄 Description

Fixes #1013

Added a new option to show all the icons on the komorebi workspace widget.
In order to distinguish between focused and non-focused windows, the icon(s) of focused window(s) on a workspace are scaled, while the non-focused icons are text sized.

https://github.com/user-attachments/assets/e5647e93-db69-4d6a-8915-1a2e0cebe8d6

I am open to change the name of the setting or even consider always loading all the icons from the state, instead of checking the config in the render.rs.

My idea was to optimize for performance, so the icons would only be loaded for all the containers if needed. If it gives little to no advantage, the code would be cleaner when all the icons are loaded regardless of the setting.

Please let me know what you prefer

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1293 **Author:** [@CtByte](https://github.com/CtByte) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `all_icons` --- ### 📝 Commits (1) - [`d140544`](https://github.com/LGUG2Z/komorebi/commit/d140544ad8c9cf6b7a569f7e82c73a3829747a5d) feat(bar): added option to show all icons on the komorebi workspace ### 📊 Changes **4 files changed** (+247 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/config.rs` (+9 -0) 📝 `komorebi-bar/src/komorebi.rs` (+69 -32) 📝 `komorebi-bar/src/render.rs` (+13 -0) 📝 `schema.bar.json` (+156 -54) </details> ### 📄 Description Fixes #1013 Added a new option to show all the icons on the komorebi workspace widget. In order to distinguish between focused and non-focused windows, the icon(s) of focused window(s) on a workspace are scaled, while the non-focused icons are text sized. https://github.com/user-attachments/assets/e5647e93-db69-4d6a-8915-1a2e0cebe8d6 --- I am open to change the name of the setting or even consider always loading all the icons from the state, instead of checking the config in the render.rs. My idea was to optimize for performance, so the icons would only be loaded for all the containers if needed. If it gives little to no advantage, the code would be cleaner when all the icons are loaded regardless of the setting. Please let me know what you prefer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:49 +01:00

adam closed this issue

2026-01-05 14:54:49 +01:00

adam referenced this issue

2026-01-05 14:54:51 +01:00

[PR #1305] refactor(cargo): upgrade to rust edition 2024 #1314

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1305