starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1278] [MERGED] Fix the default hiding behaviour not matching the documentation #1293

New Issue
Closed
opened 2026-01-05 14:54:47 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1278
Author: @Insprill
Created: 2/13/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/default-hiding-behaviour

📝 Commits (1)

  • d3ac803 fix(wm): Set the default hiding behaviour to Cloak

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 komorebi/src/lib.rs (+1 -1)

📄 Description

The Configuration Reference and Rust Doc both state that the default hiding behaviour is Cloak, however, the default was actually set to Minimize.

While this technically changes the behaviour for anyone who doesn't have this option explicitly set, I feel it's more important to match the documentation, especially considering the other options were soft deprecated almost a year ago in cc7dbde049 and the obvious issues Minimize causes when switching workspaces.

I noticed this after removing the config option since I thought it was redundant, which caused the workspace switching issues mentioned in the docs for Minimize.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1278 **Author:** [@Insprill](https://github.com/Insprill) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/default-hiding-behaviour` --- ### 📝 Commits (1) - [`d3ac803`](https://github.com/LGUG2Z/komorebi/commit/d3ac803fc9613c42e21909444a978cd041409a80) fix(wm): Set the default hiding behaviour to Cloak ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/lib.rs` (+1 -1) </details> ### 📄 Description [The Configuration Reference](https://komorebi.lgug2z.com/schema#window_hiding_behaviour) and [Rust Doc](https://github.com/LGUG2Z/komorebi/blob/2d2b6e5c1552b046b783517f4875647a88a3e00b/komorebi/src/static_config.rs#L346) both state that the default hiding behaviour is `Cloak`, however, the default was actually set to `Minimize`. While this technically changes the behaviour for anyone who doesn't have this option explicitly set, I feel it's more important to match the documentation, especially considering the other options were soft deprecated almost a year ago in cc7dbde0497ac9186d1325e3514c4d037f5af6b5 and the obvious issues `Minimize` causes when switching workspaces. I noticed this after removing the config option since I thought it was redundant, which caused the workspace switching issues mentioned in the docs for `Minimize`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:47 +01:00
adam closed this issue 2026-01-05 14:54:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1293
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?