starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1190] [MERGED] fix(bar): normalize areas of widgets #1246

New Issue
Closed
opened 2026-01-05 14:54:37 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1190
Author: @alex-ds13
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @LGUG2Z

Base: master ← Head: fix(bar)/use-all-areas

📝 Commits (10+)

  • a5e522b fix(bar): normalize areas of widgets
  • 0602f00 fix(bar): actually save the config on apply_config
  • 93d699e fix(bar): use the frame.inner_margin config
  • b555419 fix(bar): handle komorebi theme change properly
  • 4b9deef fix(bar): apply work_area_offset on config change
  • dab3354 fix(bar): use correct transparency_alpha
  • 4710df0 fix(bar): use bg color before applying transparency
  • e6f0a28 fix(bar): apply roundings on komorebi.json change
  • 0a0e880 fix(bar): fix background color clobbering
  • b489be5 fix(bar): use layout on Area to prevent shaking

📊 Changes

3 files changed (+290 additions, -130 deletions)

View changed files

📝 komorebi-bar/src/bar.rs (+223 -112)
📝 komorebi-bar/src/komorebi.rs (+34 -2)
📝 komorebi-bar/src/render.rs (+33 -16)

📄 Description

This commit changes the way each of the 3 parts of potential widgets (left, center and right) is created so that they are all done on the same way and look the same. It is using Area with different anchors for each part which makes the widgets actually center vertically properly.

This created an issue with the Bar grouping. To fix it we've made the Bar grouping change the outer panel frame instead of creating an actual group. This has the side effect (or maybe feature!) of losing the background of the outer frame. Meaning this outer frame will now have the look of the Bar grouping only. Currently it is using a fixed outer margin but this can be changed in the future to a config option.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1190 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix(bar)/use-all-areas` --- ### 📝 Commits (10+) - [`a5e522b`](https://github.com/LGUG2Z/komorebi/commit/a5e522bd99834bdbd445aa5de97db4f270241ca7) fix(bar): normalize areas of widgets - [`0602f00`](https://github.com/LGUG2Z/komorebi/commit/0602f001bdc0f4ad0ed01c32b9c19c5e91bed143) fix(bar): actually save the config on apply_config - [`93d699e`](https://github.com/LGUG2Z/komorebi/commit/93d699e94e8bef7d002b3ce2dc20184f0c0f2c37) fix(bar): use the `frame.inner_margin` config - [`b555419`](https://github.com/LGUG2Z/komorebi/commit/b5554193fb0e4f9cb21f0fd3ef1ea7ec8c51e840) fix(bar): handle komorebi theme change properly - [`4b9deef`](https://github.com/LGUG2Z/komorebi/commit/4b9deefc848c6255d7256e160b8a3ac506ea2712) fix(bar): apply work_area_offset on config change - [`dab3354`](https://github.com/LGUG2Z/komorebi/commit/dab33545e7bcd2c46a9612ae01b8850dcdf4005a) fix(bar): use correct transparency_alpha - [`4710df0`](https://github.com/LGUG2Z/komorebi/commit/4710df02e091b09912ee67afed42b1d711302562) fix(bar): use bg color before applying transparency - [`e6f0a28`](https://github.com/LGUG2Z/komorebi/commit/e6f0a285bd4132c45d4a5121f680f17ef6b76072) fix(bar): apply roundings on komorebi.json change - [`0a0e880`](https://github.com/LGUG2Z/komorebi/commit/0a0e880050e67252782293c53f0bdc09e89f8e9f) fix(bar): fix background color clobbering - [`b489be5`](https://github.com/LGUG2Z/komorebi/commit/b489be5bf8b680eb8283d3fead9406f89f5d7a7f) fix(bar): use layout on Area to prevent shaking ### 📊 Changes **3 files changed** (+290 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/bar.rs` (+223 -112) 📝 `komorebi-bar/src/komorebi.rs` (+34 -2) 📝 `komorebi-bar/src/render.rs` (+33 -16) </details> ### 📄 Description This commit changes the way each of the 3 parts of potential widgets (left, center and right) is created so that they are all done on the same way and look the same. It is using `Area` with different anchors for each part which makes the widgets actually center vertically properly. This created an issue with the `Bar` grouping. To fix it we've made the `Bar` grouping change the outer panel frame instead of creating an actual group. This has the side effect (or maybe feature!) of losing the background of the outer frame. Meaning this outer frame will now have the look of the `Bar` grouping only. Currently it is using a fixed outer margin but this can be changed in the future to a config option. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:37 +01:00
adam closed this issue 2026-01-05 14:54:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?