This commit fixes the issue related to moving windows to/from a floating workspace to a tiled workspace. Previously the start of the move would be ignored however when moving back from a tiled workspace since it didn't know about the existance of that window it would also "move" that workspace focused tiled window without physically moving it, leaving it in a weird state that seemed like it was unmanaged. This commit changes the way this mouse moves are handled and now also handles moving floating_windows and even monocle or maximized windows.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/LGUG2Z/komorebi/pull/1075
**Author:** [@alex-ds13](https://github.com/alex-ds13)
**Created:** 10/21/2024
**Status:** ✅ Merged
**Merged:** 11/1/2024
**Merged by:** [@LGUG2Z](https://github.com/LGUG2Z)
**Base:** `master` ← **Head:** `fix/moving-to-from-floats`
---
### 📝 Commits (1)
- [`8bd7dd5`](https://github.com/LGUG2Z/komorebi/commit/8bd7dd58e691e9661923229af53134fd451b8d43) fix(wm): handle moving windows to/from floating workspaces
### 📊 Changes
**3 files changed** (+294 additions, -156 deletions)
<details>
<summary>View changed files</summary>
📝 `komorebi/src/process_event.rs` (+163 -155)
📝 `komorebi/src/static_config.rs` (+1 -0)
📝 `komorebi/src/window_manager.rs` (+130 -1)
</details>
### 📄 Description
This commit fixes the issue related to moving windows to/from a floating workspace to a tiled workspace. Previously the start of the move would be ignored however when moving back from a tiled workspace since it didn't know about the existance of that window it would also "move" that workspace focused tiled window without physically moving it, leaving it in a weird state that seemed like it was unmanaged. This commit changes the way this mouse moves are handled and now also handles moving `floating_windows` and even monocle or maximized windows.
Fixes #1065
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/LGUG2Z/komorebi/pull/1075
Author: @alex-ds13
Created: 10/21/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @LGUG2Z
Base:
master← Head:fix/moving-to-from-floats📝 Commits (1)
8bd7dd5fix(wm): handle moving windows to/from floating workspaces📊 Changes
3 files changed (+294 additions, -156 deletions)
View changed files
📝
komorebi/src/process_event.rs(+163 -155)📝
komorebi/src/static_config.rs(+1 -0)📝
komorebi/src/window_manager.rs(+130 -1)📄 Description
This commit fixes the issue related to moving windows to/from a floating workspace to a tiled workspace. Previously the start of the move would be ignored however when moving back from a tiled workspace since it didn't know about the existance of that window it would also "move" that workspace focused tiled window without physically moving it, leaving it in a weird state that seemed like it was unmanaged. This commit changes the way this mouse moves are handled and now also handles moving
floating_windowsand even monocle or maximized windows.Fixes #1065
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.