starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1075] [MERGED] fix(wm): handle moving windows to/from floating workspaces #1190

New Issue
Closed
opened 2026-01-05 14:54:24 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:24 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1075
Author: @alex-ds13
Created: 10/21/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/moving-to-from-floats

📝 Commits (1)

  • 8bd7dd5 fix(wm): handle moving windows to/from floating workspaces

📊 Changes

3 files changed (+294 additions, -156 deletions)

View changed files

📝 komorebi/src/process_event.rs (+163 -155)
📝 komorebi/src/static_config.rs (+1 -0)
📝 komorebi/src/window_manager.rs (+130 -1)

📄 Description

This commit fixes the issue related to moving windows to/from a floating workspace to a tiled workspace. Previously the start of the move would be ignored however when moving back from a tiled workspace since it didn't know about the existance of that window it would also "move" that workspace focused tiled window without physically moving it, leaving it in a weird state that seemed like it was unmanaged. This commit changes the way this mouse moves are handled and now also handles moving floating_windows and even monocle or maximized windows.

Fixes #1065

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1075 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/moving-to-from-floats` --- ### 📝 Commits (1) - [`8bd7dd5`](https://github.com/LGUG2Z/komorebi/commit/8bd7dd58e691e9661923229af53134fd451b8d43) fix(wm): handle moving windows to/from floating workspaces ### 📊 Changes **3 files changed** (+294 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_event.rs` (+163 -155) 📝 `komorebi/src/static_config.rs` (+1 -0) 📝 `komorebi/src/window_manager.rs` (+130 -1) </details> ### 📄 Description This commit fixes the issue related to moving windows to/from a floating workspace to a tiled workspace. Previously the start of the move would be ignored however when moving back from a tiled workspace since it didn't know about the existance of that window it would also "move" that workspace focused tiled window without physically moving it, leaving it in a weird state that seemed like it was unmanaged. This commit changes the way this mouse moves are handled and now also handles moving `floating_windows` and even monocle or maximized windows. Fixes #1065 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:24 +01:00
adam closed this issue 2026-01-05 14:54:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?