Commit Graph
226 Commits
Author SHA1 Message Date
LGUG2Z 7fcc647b86 docs(schema): add asc schema for macos 2026-01-30 20:34:11 -08:00
LGUG2Z ebbd9eee35 docs(readme): prepare to make repo public 2026-01-30 11:35:30 -08:00
LGUG2Z 72ec96c2f6 chore(deps): cargo update 2026-01-27 18:16:19 -08:00
LGUG2Z 1192a103d2 fix(wm): distinguish separate windows from tabs for tabbed apps
When Finder is configured as a tabbed application, opening multiple
separate Finder windows (not tabs within the same window) prevented
focusing between those windows using komorebic focus commands.

The tab detection logic uses geometry comparison (tab_rect == main_rect)
to determine if a window event represents a tab change. This fails when
separate windows from the same application have identical geometry after
tiling, causing them to be incorrectly treated as tabs within a single
window.

This commit adds window ID verification as an additional requirement for
tab detection. For Show events, both geometry AND window IDs must match
for the event to be classified as a tab (preventing new container
creation). For FocusChange events, we verify the stored element's window
ID matches the container's stored ID to confirm legitimate tab switches
within the same window.

The geometry check is preserved to maintain existing tab detection, but
now requires window ID confirmation to prevent false positives when
separate windows happen to share identical positions and dimensions.

Additionally, this commit fixes the Window::focus() function for tabbed
applications to prefer using the stored element when valid, only falling
back to main_window() when the element is invalid (tab was closed). This
allows focusing specific windows even for tabbed applications instead of
always focusing the main/frontmost window.
2026-01-27 18:12:23 -08:00
LGUG2Z b5215a2842 feat(config): expose tabbed and titleless apps via asc
This commit removes the hardcoded entries in TABBED_APPLICATIONS for
Finder and Ghostty, and instead leaves this for users to source either
through their own configs using the "tabbed_applications" config option
or via an ASC file.

There is a slight discrepancy in the two schemas as the personal config
file will accept an Exe string identifying the app, whereas the ASC goes
with a full MatchingRule to keep the ASC consistent.

However, for both tabbed and titleless application options as exposed on
the ASC schema, when read in komorebi it will only accept
MatchingRule::Simple with an Exe identifier.
2026-01-27 17:50:44 -08:00
LGUG2Z 5bb1295a3b fix(wm): clamp layouts to work area boundaries
Resize adjustments can cause container layouts to overflow beyond the
monitor's work area boundaries, bleeding into adjacent monitors.

This happens because the resize adjustment system modifies container
dimensions without validating that the final calculated positions stay
within the monitor's bounds.

On multi-monitor setups (e.g. ultrawide + MacBook display), a large
resize adjustment on one container can push adjacent containers past the
monitor edge, making them visible on the neighboring display.

This commit adds boundary clamping after layout calculation but before
padding is applied. If a layout's calculated position exceeds the work
area bounds (horizontally or vertically), we clamp it to stay within the
monitor's usable space.

Additionally, a unit test validates that layouts with aggressive resize
adjustments (matching the reported issue) are properly clamped to
prevent overflow.
2026-01-20 14:24:05 -08:00
LGUG2Z 08794ba317 fix(wm): prevent ws reconciliation when closing last ws window
When the last window on a workspace is closed, macOS automatically
activates another app (often on a different workspace). This app's focus
event triggers workspace reconciliation, switching the user away from
the now-empty workspace they (presumably) intended to stay on.

The issue is a race condition: by the time we try to activate Finder to
prevent the unwanted focus change, the other app's activation event has
already been queued and will still get processed.

This commit enusres that we skip reconciliation when the current
workspace is empty; this indicates the user just closed the last window
and should stay on that workspace, not follow workspace focus to
wherever macOS arbitrarily activates an app.

Additionally, we activate Finder when a workspace becomes empty to match
native macOS behavior (clicking on empty desktop activates Finder
without opening a window).
2026-01-12 13:39:52 -08:00
LGUG2Z 7c1ab9a6cc fix(wm): handle ghost tiles from electron apps hijacking cmd+w
Some Electron apps like Discord hijack CMD+W to send
`AXApplicationHidden` instead of properly closing/destroying the window.

This causes ghost tiles because the window still exists in the
accessibility API with valid geometry even though it is no longer
visible on the screen.

When `AXApplicationHidden` fires for an app with exactly 1 window, we
now force-reap that window by passing an empty `valid_window_ids` list.

This treats single- window hide events as closes, which is the correct
behavior for apps that hijack CMD+W. Apps with multiple windows continue
to use normal orphan reaping.

I'm still not sure if this is too broad; we may need to use an allowlist
approach for this if it causes changes with other apps.
2026-01-12 13:20:41 -08:00
LGUG2Z 63409addb1 build(nix): remove mkdocs from devshell 2026-01-12 12:54:38 -08:00
LGUG2Z d91e14bd71 build(just): consolidate schemapub target 2026-01-04 21:11:28 -08:00
LGUG2Z 321bfb129c chore(deps): flake.lock: Update
Flake lock file updates:

• Updated input 'crane':
    'github:ipetkov/crane/2b3a5a88d852575758e1eb6ac9ee677fcd633fc1' (2025-12-05)
  → 'github:ipetkov/crane/7d59256814085fd9666a2ae3e774dc5ee216b630' (2026-01-03)
• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/2cccadc7357c0ba201788ae99c4dfa90728ef5e0' (2025-11-21)
  → 'github:hercules-ci/flake-parts/a34fae9c08a15ad73f295041fec82323541400a9' (2025-12-15)
• Updated input 'flake-parts/nixpkgs-lib':
    'github:nix-community/nixpkgs.lib/719359f4562934ae99f5443f20aa06c2ffff91fc' (2025-10-29)
  → 'github:nix-community/nixpkgs.lib/2075416fcb47225d9b68ac469a5c4801a9c4dd85' (2025-12-14)
• Updated input 'git-hooks-nix':
    'github:cachix/git-hooks.nix/b68b780b69702a090c8bb1b973bab13756cc7a27' (2025-12-16)
  → 'github:cachix/git-hooks.nix/f0927703b7b1c8d97511c4116eb9b4ec6645a0fa' (2026-01-01)
• Updated input 'git-hooks-nix/flake-compat':
    'github:edolstra/flake-compat/f387cd2afec9419c8ee37694406ca490c3f34ee5' (2025-10-27)
  → 'github:NixOS/flake-compat/5edf11c44bc78a0d334f6334cdaf7d60d732daab' (2025-12-29)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/a672be65651c80d3f592a89b3945466584a22069' (2025-12-05)
  → 'github:NixOS/nixpkgs/16c7794d0a28b5a37904d55bcca36003b9109aaa' (2026-01-02)
• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/086fd19a68e80fcc8a298e9df4674982e4c498a6' (2025-12-06)
  → 'github:oxalica/rust-overlay/1d3f83babdd21e16bf5cfe0f1efcb4f49ee1bc2c' (2026-01-05)
• Updated input 'treefmt-nix':
    'github:numtide/treefmt-nix/5b4ee75aeefd1e2d5a1cc43cf6ba65eba75e83e4' (2025-11-12)
  → 'github:numtide/treefmt-nix/d56486eb9493ad9c4777c65932618e9c2d0468fc' (2026-01-03)
2026-01-04 20:35:21 -08:00
LGUG2Z 6b8ad3c0bd chore(deps): cargo update 2026-01-04 20:20:28 -08:00
LGUG2Z 8453c428dd feat(cli): add dedicated permissions command
This commit adds a dedicated `komorebic permissions` command so that
users can quickly open the relevant Permissions dialogs in System
Settings at any time (i.e. after upgrades).
2026-01-04 19:57:20 -08:00
LGUG2Z 10c0d4215b fix(cli): update enable-autostart to run at load + specify log paths
This commit updates the plist generated by `komorebic enable-autostart`
to add RunAtLoad = true and paths in /tmp/ for StandardOutPath and
StandardErrorPath.
2026-01-04 19:52:25 -08:00
LGUG2Z 8b4604d47e fix(border): maintain config compat with windows opts
This commit adds a 7px border offset adjustment to the BORDER_OFFSET
value wherever it is used to maintain config compatibility with komorebi
for Windows.

Windows has stupid 7px invisible borders around every app window which
have to be taken into account when setting the values for these options,
but this is not the case on macOS.

However, if we don't replicate the factoring in of those invisible
borders into our offset calculations, the same border config on Windows
and macOS looks vastly different.
2026-01-04 19:40:40 -08:00
LGUG2Z c23bf462cb feat(bar): make explicit monitor config optional
This commit makes the monitor configuration option for the komorebi-bar
optional, defaulting to index 0. Additionally, the automatic work area
adjustment has been re-enabled for displays where are not built-in
Macbook displays.
2026-01-04 14:29:21 -08:00
LGUG2Z aac1e9ecf2 build(just): start using vararg build/install target variants 2026-01-03 11:39:26 -08:00
LGUG2Z 41001da1f0 refactor(bar): inline defaults in schemars attrs 2026-01-03 11:30:40 -08:00
LGUG2Z ca94a57dd5 feat(bar): render at notch level on macbooks
This commit uses raw-window-handle to access the NSWindow of the bar and
set the window level to `kCGBackstopMenuLevel` (-20), positioning the
bar behind the menu bar, and at the same level as the notch on Macbook
screens.

This approach means the bar occupies space already excluded from the
work area by the menu bar, so the automatic work area offset calculation
is no longer needed and has been commented out. (I think... Need to
validate this on regular non-Macbook external displays...)

The explicit user-configured `work_area_offset` option is preserved for
users who want more flexibility.
2026-01-03 10:13:17 -08:00
LGUG2Z 6b52e4b3a4 fix(wm): treat empty titles as unmanageable
Some apps like Raycast do dumb stuff like reporting empty strings as
titles to the system. If your app doesn't have a title, don't give it an
empty string as a title!

This commit adds an explicit string emptiness check on titles when
evaluating windows for management eligibility.
2026-01-02 15:19:14 -08:00
LGUG2Z 88a04c2078 feat(config): expose opts for titleless and tabbed applications
This commit exposes configs for titleless (i.e. MS Edge installed apps)
and tabbed (i.e. Ghostty) applications. Ghostty is no longer hard coded
as a tabbed application and should be added via config.
2026-01-02 10:21:46 -08:00
LGUG2Z 8e6aa34bbf fix(animation): disable on stacking operations
This commit disables animations on stacking operations because it's just
too much of a headache. Additionally, the borders get screwed up
sometimes on unstacking, so we'll just go nuclear and destroy and
recreate them on an unstack or unstack-all op.
2026-01-01 16:22:10 -08:00
LGUG2Z 64ee9b6e0d fix(wm): consider window count when calculating scrolling column width
This commit fixes the stupidest of stupid bugs. Column width
calculations on the Scrolling layout should take the number of windows
into account, especially when lower than the configured column count.
2026-01-01 16:10:02 -08:00
LGUG2Z 8f542b6c3b fix(wm): ensure tabbed apps are known in monocle mode
This commit ensures that we detect tabbed applications appropriately
when they are in monocle mode when handling FocusChange so that
switching tabs doesn't break monocle mode or the layout it has been
toggled on from.
2026-01-01 16:10:02 -08:00
LGUG2Z 3a7758cd60 fix(wm): preserve active tab when focusing tabbed applications
This commit ensures that when focusing back to a tabbed application, we
use the current main window element instead of the stored element which
may point to a stale tab, and we also update the stored window element
when the user switches tabs, so that borders can update correctly.
2026-01-01 16:09:59 -08:00
LGUG2Z f46fe659ac chore(deps): cargo update 2025-12-31 18:44:14 -08:00
LGUG2Z 9b6b86cdea fix(wm): send manual move/resize end events on mouse release
The Acessibility API does not reliably fire AXWindowMoved and
AXWindowResized notifications after the mouse button is released,
causing drag-to-swap and drag-to-resize operations to fail.

This sends manual MoveEnd and ResizeEnd events from the input
event listener when LeftMouseUp is detected, ensuring these
operations complete reliably.

Resizing windows while dragging doesn't really work and has been noted
in the known-issues.md file.
2025-12-31 18:41:44 -08:00
LGUG2Z 05cd7832e8 fix(wm): process notifications from destroyed windows
When closing a window with CMD+W, the AXUIElementDestroyed notification
has an empty title. We need to add an is_destroyed override for these
AXUIElementDestroyed notifications without a title so that they can be
processed.

This commit also fixes a race condition exposed by the above fix where
the reaper thread sometimes removes the window before the reap function
tries to remove it during event processing. When this happens, we can
just ignore the error and continue instead of propagating it up and
interrupting the event processing loop until the user's next manual
interaction with another window.
2025-12-31 16:13:24 -08:00
LGUG2Z 49bdf41bfc refactor(schema): simplify defaults in static_config 2025-12-31 12:38:37 -08:00
LGUG2Z 27454c3186 refactor(config): pull theme structs from komorebi-themes
Centralized both KomorebiTheme and KomobarTheme in the komorebi-themes
module in komorebi for Windows.

This commit removes the duplicated references in komorebi for Mac and
just pulls in those; now we only have to update the docs in one place.

Regenerated all the schemas after pulling in the changes.
2025-12-27 22:24:07 -08:00
LGUG2Z ff8c852e62 docs(schema): ensure every enum variant has a renderable title 2025-12-27 20:07:17 -08:00
LGUG2Z b421043494 docs(schema): ensure all public-facing bar config opts have docstrings 2025-12-27 14:46:29 -08:00
LGUG2Z 93bdb327f0 chore(deps): bump komorebi-themes and regen docs 2025-12-27 13:45:59 -08:00
LGUG2Z 73ca25500b docs(config): ensure all public-facing static config opts have docstrings 2025-12-26 21:29:05 -08:00
LGUG2Z f290c7e037 docs(config): encode defaults of unwrapped options into schema
This commit ensures that the various default values that the different
Option<T> config properties can be unwrapped to are encoded by schemars
so that they can be picked up by docgen and nixgen.
2025-12-26 15:19:33 -08:00
LGUG2Z 4e66b46e87 docs(schema): clean up unused schema opts from windows
This commit removes some Windows-only schema opts from StaticConfig and
updates the justfile to start generating content for the new Starlight
documentation site.
2025-12-26 11:02:47 -08:00
LGUG2Z 49ac638d4e feat(cli): add custom output dir for docgen cmd 2025-12-26 09:21:48 -08:00
LGUG2Z b51eb8aab2 feat(nix): add nix-darwin module
This commit adds a nix-darwin module for komorebi and komorebi-bar,
exposed via `darwinModules.default` and `darwinModules.komorebi`.

The module provides the following options:

* `services.komorebi.enable`: enables the komorebi launchd agent
* `services.komorebi.config`: typed Nix configuration (defaults to example
  config)
* `services.komorebi.configFile`: path to a JSON config file (validated
  against schema)
* `services.komorebi.logLevel`: log verbosity level
* `services.komorebi.applicationSpecificConfiguration`: fetches
  app-specific configs from remote GitHub repositories at pinned
  revisions

* `services.komorebi-bar.enable`: enables komorebi-bar launchd agent(s)
* `services.komorebi-bar.bars.<name>`: named bar instances, one per
  monitor
* `services.komorebi-bar.bars.<name>.config`: typed Nix configuration per
  bar
* `services.komorebi-bar.bars.<name>.configFile`: path to a JSON config
  file per bar

The applicationSpecificConfiguration option supports multiple sources,
allowing users to combine the upstream default from
LGUG2Z/komorebi-application-specific-configuration with their own
personal overrides from other repositories.

When configFile is specified, the JSON file is validated against the
flake's version of the schema before being passed to the binary.

A new flake check, `darwin-module-validation`, validates the module
options and exercises the configFile validation against the example
JSON files loaded into `komorebic` for the `quickstart` cmd.
2025-12-24 17:18:44 -08:00
LGUG2Z 23aca28267 build(nix): add generated module opts and validation
This commit adds NixOS module option generation for komorebi and
komorebi-bar configurations, along with a nix and JSONSchema validation
test harness that runs as part of `nix flake check`.

`schemars-nixgen` (same as `schemars-docgen`, not sure if I'm gonna
release this...) generates strongly-typed Nix option definitions from
the generated JSONSchema files, allowing users to write type-checked Nix
configurations that map directly to the config files.

This will eventually be plugged into a nix-darwin module which I have
yet to start writing.
2025-12-24 17:18:41 -08:00
LGUG2Z 6c575126ad perf(animation): hide scrolling windows to nearest edge
This commit improves the scrolling layout animation by dynamically
choosing the window hiding position based on which side of the viewport
the window is scrolling out of.

Previously, all hidden windows went to the same corner (based on the
global window_hiding_position setting), causing jarring animations when
windows scrolled back into view from the opposite side of the screen.

Now windows scrolling off the left edge hide to the bottom-left, and
windows scrolling off the right edge hide to the bottom-right. This
ensures windows animate back in from the side they scrolled out to.
2025-12-24 08:53:20 -08:00
LGUG2Z 39749acd84 chore(deps): update dependencies.json 2025-12-24 08:36:22 -08:00
LGUG2Z b922dc3faa refactor(nix): bring shell directly into flake and pin cargo 2025-12-24 08:36:18 -08:00
LGUG2Z 6a7836067b chore(deps): cargo update 2025-12-23 20:19:57 -08:00
LGUG2Z a56f2b42d4 docs(schema): remove custom layout and stackbar refs
This commit removes references to custom layouts and the stackbar as
these are end-of-life komorebi for Windows features which are not being
ported.
2025-12-23 20:07:46 -08:00
LGUG2Z a8a8c2dade perf(animation): suppress observer notifications during animations
This commit prevents the event channel from being flooded with
AXWindowMoved and AXWindowResized notifications during window
animations.

Previously, every frame of an animation would trigger macOS
accessibility notifications, which were then converted to MoveEnd and
ResizeEnd events. With a 60 FPS animation, this meant ~15 events per
window per animation, quickly filling the bounded channel (capacity 20)
and causing "channel is full; dropping notification" warnings.

The fix removes kAXWindowMovedNotification and kAXWindowResizedNotification
from the window's observer in pre_render() before the animation starts,
then restores them in post_render() after the animation completes. This
stops notifications at the source rather than filtering them later.
2025-12-23 20:07:40 -08:00
LGUG2Z af77e2c944 perf(deps): minimize objc2 cargo features to reduce build time
This commit optimizes the objc2 dependency tree by disabling default
features and enabling only the minimal set of features actually used
by the codebase. This reduces compilation time and dependency bloat.

I was meant to do this earlier but during the initial implementation it was
easier to just pull in everything. Now that we are getting ready for a public
release it's time to improve on this.

I ended up:

* Removing unused direct dependencies:
  - objc2-core-services
  - objc2-core-video

* Setting `default-features = false` on all objc2 crates and added only
  the specific features required for the types and methods used

* Updating objc2, objc2-app-kit, objc2-foundation,
  objc2-application-services, objc2-core-foundation, objc2-core-graphics,
  and objc2-quartz-core with minimal feature sets

After all those changes, the following transitive dependencies are no longer
pulled in: objc2-metal, objc2-core-image, objc2-core-data, objc2-cloud-kit,
objc2-core-text, and loads of unused Foundation/AppKit class bindings.

Some before and after numbers:

| Metric                          | Before  | After   | Change   |
|---------------------------------|---------|---------|----------|
| objc2 dep lines (komorebi)      | 84      | 50      | -40.5%   |
| objc2 dep lines (komorebi-bar)  | 91      | 59      | -35.2%   |
| Dependency tree (komorebi)      | 973     | 917     | -5.8%    |
| Dependency tree (komorebi-bar)  | 1181    | 1131    | -4.2%    |
| Clean build time                | 3m 05s  | 2m 21s  | -23.8%   |

The almost 24% reduction in clean build time is a big win!
2025-12-23 19:38:11 -08:00
LGUG2Z f42457e2e8 feat(animation): add window movement animations
This commit adds window movement animations to komorebi for macOS,
maintaining configuration API compatibility with komorebi for Windows.

The animation system is adapted from the Windows implementation but uses
macOS-specific APIs for screen update batching and accessibility
control, and borrows heavily from the implementation details of
animations in rift.

In order to have decent performance, there are some calls to private
APIS. For this reason, the animation feature will be marked as "UNSAFE".

UNSAFE features should be expected to break between major operating
system updates, and depending on which way I want to go, may only
support one major macOS version at a time (i.e. they will not have a
backwards compatibility guarantee with previous versions of macOS).

This currently look awful when used with the Scrolling layout, but looks
relatively good with other layouts. As with Windows, the animations
when two windows of very different sizes change position aren't great.

Some high level notes on the implementation:

* Uses the private SkyLight framework for screen update batching via
  SLSDisableUpdate/SLSReenableUpdate - these APIs prevent visual flicker
  by compositing all window position changes at once rather than updating
  each window individually during layout operations
* AnimationEngine runs animations in background threads with frame-based
  timing, supporting cancellation when new animations are triggered for
  the same window
* MovementRenderDispatcher implements the RenderDispatcher trait to
  interpolate window positions using configurable easing functions
* All 30+ easing styles from the Windows implementation are supported,
  including standard CSS-style functions and CubicBezier for custom curves
* Enhanced User Interface (AXEnhancedUserInterface) is temporarily
  disabled during window positioning operations for better performance
* The Transparency animation prefix is not supported on macOS as there
  is no equivalent to the Win32 transparency feature

This feature is off-by-default and can be enabled in the static config
or via komorebic commands (animation, animation-duration, animation-fps,
animation-style).
2025-12-23 19:04:33 -08:00
LGUG2Z f6bfae3103 docs(schema): avoid duplicating display format enums in bar
This commit also addresses some clippy warnings.
2025-12-23 17:07:56 -08:00
LGUG2Z 1e71cb7d92 docs(schema): publish versioned schema docs to lgug2z.com 2025-12-23 12:00:13 -08:00
LGUG2Z 1cb3327395 chore(deps): bump schemars to 1.1 and netdev to 0.40 2025-12-21 10:00:55 -08:00