feat(e2e): no known-failure marker for a build that tracks a user's maximize

maximizing.user is a known difference only on a komorebi without 3fa3d429
(track a window the user maximizes or restores); on a build that has it
the step runs as any other.
This commit is contained in:
LGUG2Z committed 2026-10-30 18:22:45 -07:00
1 parent 9818a1b885
commit a007996f6a
2 files changed
+29 -1

No files matched your search

+11 -1
View File
@@ -79,6 +79,13 @@ KNOWN_STEPS = {
}
# the commit of komorebi's `next` that fixed what a step is known to fail, so
# that a build that has it does not get the marker
KNOWN_STEPS_FIXED_BY = {
"maximizing.user": "3fa3d429",
}
class GuestDied(RuntimeError):
"""QEMU exited while a scenario was running: not what kfw did."""
@@ -135,7 +142,10 @@ def _suite(checks: "RecordedChecks", *steps):
for step in steps:
began = time.monotonic()
counted = checks.passed + checks.failed + len(checks.known)
checks.expected = KNOWN_STEPS.get(step.name)
fix = KNOWN_STEPS_FIXED_BY.get(step.name)
checks.expected = (
None if fix and _contains(fix) else KNOWN_STEPS.get(step.name)
)
known_before = len(checks.known)
try:
results.extend(run_suite(checks, step))
@@ -324,3 +324,21 @@ def test_the_wallpaper_is_asked_of_the_shell_for_a_display() -> None:
assert agent.executed[-2][-2:] == ("get", "1")
assert agent.executed[-1][-3:] == ("set", "1", "C:\\x y.png")
def test_a_known_step_has_no_marker_on_a_commit_that_has_its_fix(
monkeypatch: pytest.MonkeyPatch,
) -> None:
from komorebi_vm.core.suite import shared
def user(checks: run.RecordedChecks) -> None:
checks.check("b", False)
user.__module__ = "komorebi_vm.core.scenarios.maximizing"
monkeypatch.setattr(run, "_contains", lambda fix, repo=None: True)
checks = run.RecordedChecks()
run._suite(checks, shared(user, checks))
assert checks.failed == 1
assert checks.known == []