mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-17 06:11:21 +01:00
feat(e2e): the known difference of maximizing.user after kfw tracks a user's maximize
On a komorebi with 3fa3d429 the step passes its tracking checks; what is
left is that toggle-float and stack left/right are not ignored while a
window is maximized. The marker says so for such a build.
This commit is contained in:
1 parent
b1d053b358
commit
345ddf30ea
2 files changed
+15
-8
No files matched your search
@@ -79,10 +79,16 @@ KNOWN_STEPS = {
|
||||
}
|
||||
|
||||
|
||||
# the commit of komorebi's `next` that fixed what a step is known to fail, so
|
||||
# that a build that has it does not get the marker
|
||||
# the commit of komorebi's `next` that fixed what a step is known to fail, and
|
||||
# what it still fails on a build that has it: the marker is the first reason
|
||||
# before it and the second after it
|
||||
KNOWN_STEPS_FIXED_BY = {
|
||||
"maximizing.user": "3fa3d429",
|
||||
"maximizing.user": (
|
||||
"3fa3d429",
|
||||
"kfw tracks a user's maximize, but toggle-float (it floats the window "
|
||||
"and ends the maximize) and stack left/right (they stack the others) "
|
||||
"are not ignored while a window is maximized",
|
||||
),
|
||||
}
|
||||
|
||||
|
||||
@@ -142,9 +148,10 @@ def _suite(checks: "RecordedChecks", *steps):
|
||||
for step in steps:
|
||||
began = time.monotonic()
|
||||
counted = checks.passed + checks.failed + len(checks.known)
|
||||
fix = KNOWN_STEPS_FIXED_BY.get(step.name)
|
||||
fixed = KNOWN_STEPS_FIXED_BY.get(step.name)
|
||||
checks.expected = (
|
||||
None if fix and _contains(fix) else KNOWN_STEPS.get(step.name)
|
||||
fixed[1] if fixed and _contains(fixed[0])
|
||||
else KNOWN_STEPS.get(step.name)
|
||||
)
|
||||
known_before = len(checks.known)
|
||||
try:
|
||||
|
||||
@@ -330,7 +330,7 @@ def test_the_wallpaper_is_asked_of_the_shell_for_a_display() -> None:
|
||||
assert agent.executed[-1][-3:] == ("set", "1", "C:\\x y.png")
|
||||
|
||||
|
||||
def test_a_known_step_has_no_marker_on_a_commit_that_has_its_fix(
|
||||
def test_a_known_step_has_the_narrower_marker_on_a_commit_that_has_the_fix(
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
from komorebi_vm.core.suite import shared
|
||||
@@ -344,5 +344,5 @@ def test_a_known_step_has_no_marker_on_a_commit_that_has_its_fix(
|
||||
|
||||
run._suite(checks, shared(user, checks))
|
||||
|
||||
assert checks.failed == 1
|
||||
assert checks.known == []
|
||||
assert checks.failed == 0
|
||||
assert "toggle-float" in checks.known[0]
|
||||
Reference in new issue
Block a user