starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-03-19 07:54:04 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

fix(komorebi): raise windows and border to top, not topmost

Browse Source 
topmost has a special meaning, in that it is a sticky raise, which is
not what we want - we don't want to be permanently above all other
windows, as this leads to bugs where for example the windows can end up
stuck above non-topmost windows in a different security context, such as
programs running with administrator priviliges.
This commit is contained in:
James Tucker
2024-02-25 14:29:08 -08:00
committed by جاد
parent 10ae60f79b
commit 0c2e37e127
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
komorebi/src/windows_api.rs
View File

@@ -103,7 +103,7 @@ use windows::Win32::UI::WindowsAndMessaging::GWL_EXSTYLE;
use windows::Win32::UI::WindowsAndMessaging::GWL_STYLE;
use windows::Win32::UI::WindowsAndMessaging::GW_HWNDNEXT;
use windows::Win32::UI::WindowsAndMessaging::HWND_BOTTOM;
use windows::Win32::UI::WindowsAndMessaging::HWND_TOPMOST;
use windows::Win32::UI::WindowsAndMessaging::HWND_TOP;
use windows::Win32::UI::WindowsAndMessaging::LWA_ALPHA;
use windows::Win32::UI::WindowsAndMessaging::LWA_COLORKEY;
use windows::Win32::UI::WindowsAndMessaging::SET_WINDOW_POS_FLAGS;
@@ -358,7 +358,7 @@ impl WindowsApi {
bottom: layout.bottom + shadow_rect.bottom,
};
let position = if top { HWND_TOPMOST } else { HWND_BOTTOM };
let position = if top { HWND_TOP } else { HWND_BOTTOM };
Self::set_window_pos(hwnd, &rect, position, flags.bits())
}
@@ -369,7 +369,7 @@ impl WindowsApi {
pub fn raise_window(hwnd: HWND) -> Result<()> {
let flags = SetWindowPosition::NO_MOVE;
let position = HWND_TOPMOST;
let position = HWND_TOP;
Self::set_window_pos(hwnd, &Rect::default(), position, flags.bits())
}
@@ -380,12 +380,13 @@ impl WindowsApi {
SetWindowPosition::NO_ACTIVATE
};
// Always raise the border window to topmost, so that when it is a
// single-pixel inset border, it always draws atop the window (i.e.
// support an offset of -1 that draws over the Windows 11 default
// translucent single pixel border, while reamining visible in cases
// such as the EPIC Games launcher that uses an opaque custom border).
let position = HWND_TOPMOST;
// Always raise the border window to the top, but not overlapping
// topmost windows, so that when it is a single-pixel inset border, it
// always draws atop the window (i.e. support an offset of -1 that
// draws over the Windows 11 default translucent single pixel border,
// while reamining visible in cases such as the EPIC Games launcher that
// uses an opaque custom border).
let position = HWND_TOP;
Self::set_window_pos(hwnd, layout, position, flags.bits())
}