starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] AutoApprovers route not work as expect #770

New Issue
Closed
opened 2025-12-29 02:23:48 +01:00 by adam · 5 comments
adam commented 2025-12-29 02:23:48 +01:00
Owner
Copy Link

Originally created by @njzydark on GitHub (Aug 21, 2024).

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

10.42.7.0/24 not auto approved by this acl config:

{
  "autoApprovers": {
    "routes": {
      "10.42.0.0/16": [
        "k8s"
      ]
}

when use this, it work:

{
  "autoApprovers": {
    "routes": {
      "10.42.7.0/24": [
        "k8s"
      ]
}

Expected Behavior

10.42.7.0/24 auto approved by this acl config:

{
  "autoApprovers": {
    "routes": {
      "10.42.0.0/16": [
        "k8s"
      ]
}

Steps To Reproduce

use this acl config to test 10.42.7.0/24 :

{
  "autoApprovers": {
    "routes": {
      "10.42.0.0/16": [
        "k8s"
      ]
}

Environment

- OS: Ubuntu 22.04
- Headscale version: v0.23.0-beta2
- Tailscale version: 1.68.2

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response

Originally created by @njzydark on GitHub (Aug 21, 2024). ### Is this a support request? - [X] This is not a support request ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current Behavior `10.42.7.0/24` not auto approved by this acl config: ```json { "autoApprovers": { "routes": { "10.42.0.0/16": [ "k8s" ] } ``` when use this, it work: ```json { "autoApprovers": { "routes": { "10.42.7.0/24": [ "k8s" ] } ``` ### Expected Behavior `10.42.7.0/24` auto approved by this acl config: ```json { "autoApprovers": { "routes": { "10.42.0.0/16": [ "k8s" ] } ``` ### Steps To Reproduce use this acl config to test `10.42.7.0/24` : ```json { "autoApprovers": { "routes": { "10.42.0.0/16": [ "k8s" ] } ``` ### Environment ```markdown - OS: Ubuntu 22.04 - Headscale version: v0.23.0-beta2 - Tailscale version: 1.68.2 ``` ### Runtime environment - [ ] Headscale is behind a (reverse) proxy - [ ] Headscale runs in a container ### Anything else? _No response_
adam added the bug label 2025-12-29 02:23:48 +01:00
adam closed this issue 2025-12-29 02:23:48 +01:00
adam commented 2025-12-29 02:23:48 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 2, 2024):

I must have missed this one, quick check, did this work in any prior release?

@kradalby commented on GitHub (Sep 2, 2024): I must have missed this one, quick check, did this work in any prior release?
adam commented 2025-12-29 02:23:48 +01:00
Author
Owner
Copy Link

@njzydark commented on GitHub (Sep 2, 2024):

I must have missed this one, quick check, did this work in any prior release?

The specific version is unclear, but there is indeed a version that is useful.

@njzydark commented on GitHub (Sep 2, 2024): > I must have missed this one, quick check, did this work in any prior release? The specific version is unclear, but there is indeed a version that is useful.
adam commented 2025-12-29 02:23:49 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 2, 2024):

It would be helpful if you have the opportunity to help me track down where the change was introduced.

@kradalby commented on GitHub (Sep 2, 2024): It would be helpful if you have the opportunity to help me track down where the change was introduced.
adam commented 2025-12-29 02:23:49 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 5, 2024):

@njzydark I have added 6f1bba5 (#2105) to validate this error, but it does approve the route as expected. I am not able to reproduce this.

Can you please read the test to see if there is anything I am missing?

@kradalby commented on GitHub (Sep 5, 2024): @njzydark I have added [`6f1bba5` (#2105)](https://github.com/juanfont/headscale/pull/2105/commits/6f1bba5342e141fc6c71cf5291e3f471af72eceb) to validate this error, but it does approve the route as expected. I am not able to reproduce this. Can you please read the test to see if there is anything I am missing?
adam commented 2025-12-29 02:23:49 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 5, 2024):

To ensure that there is nothing later in the chain that strips this route, I also added a e2e integration test here 95ae548 (#2105).

@kradalby commented on GitHub (Sep 5, 2024): To ensure that there is nothing later in the chain that strips this route, I also added a e2e integration test here [`95ae548` (#2105)](https://github.com/juanfont/headscale/pull/2105/commits/95ae548a20649623b31d0cf29dfadc344067a96b).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?