starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #770] [CLOSED] Fixes #766 Feature optional hostname suffix #1634

New Issue
Closed
opened 2025-12-29 02:31:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/770
Author: @shanna
Created: 8/30/2022
Status: ❌ Closed

Base: main ← Head: feature-optional-hostname-suffix

📝 Commits (2)

  • 84c78d2 Optional machine name suffixes.
  • e71d32c Changelog and config example for optional hostname prefixes.

📊 Changes

5 files changed (+64 additions, -34 deletions)

View changed files

📝 CHANGELOG.md (+6 -0)
📝 config-example.yaml (+6 -0)
📝 config.go (+3 -0)
📝 machine.go (+12 -14)
📝 machine_test.go (+37 -20)

📄 Description

This PR fixes #766 by making hostname suffixes optional and off by default.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/770 **Author:** [@shanna](https://github.com/shanna) **Created:** 8/30/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature-optional-hostname-suffix` --- ### 📝 Commits (2) - [`84c78d2`](https://github.com/juanfont/headscale/commit/84c78d21aa9ececfcbe1fa3450291b0eaa52b1c9) Optional machine name suffixes. - [`e71d32c`](https://github.com/juanfont/headscale/commit/e71d32c53e9c5a88dc475bd2c7f6976d0e8b8e06) Changelog and config example for optional hostname prefixes. ### 📊 Changes **5 files changed** (+64 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -0) 📝 `config-example.yaml` (+6 -0) 📝 `config.go` (+3 -0) 📝 `machine.go` (+12 -14) 📝 `machine_test.go` (+37 -20) </details> ### 📄 Description This PR fixes #766 by making hostname suffixes optional and off by default. - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:01 +01:00
adam closed this issue 2025-12-29 02:31:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1634
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?