starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

OIDC auth in 0.16.2 fails with "Failed to decode id token claims" #312

New Issue
Closed
opened 2025-12-29 01:26:34 +01:00 by adam · 8 comments
adam commented 2025-12-29 01:26:34 +01:00
Owner
Copy Link

Originally created by @kyhwana on GitHub (Aug 16, 2022).

Bug description
After upgrading from 0.16.0 to 0.16.2 users are unable to authenticate using azure oidc, they get the error Failed to decode id token claims
In the logs is the following error:

Aug 16 14:16:32 <machinefqd>  headscale[1125980]: 2022-08-16T02:16:32Z ERR home/runner/work/headscale/headscale/oidc.go:324 > Failed to decode id token claims error="json: Unmarshal(non-pointer headscale.IDTokenClaims)"

Is this related to the changed line in oidc.go? if err := idToken.Claims(claims); err != nil {
To Reproduce

Have a user log out of the tailscale client then reauthenticate, using Azure AD OIDC. When the browser window opens it will attempt to auth via AAD and fail with the above error.

Context info
Headscale version 0.16.2.
tailscale client version 1.28.0

Originally created by @kyhwana on GitHub (Aug 16, 2022). <!-- Headscale is a multinational community across the globe. Our common language is English. Please consider raising the bug report in this language. --> **Bug description** After upgrading from 0.16.0 to 0.16.2 users are unable to authenticate using azure oidc, they get the error ```Failed to decode id token claims``` In the logs is the following error: ``` Aug 16 14:16:32 <machinefqd> headscale[1125980]: 2022-08-16T02:16:32Z ERR home/runner/work/headscale/headscale/oidc.go:324 > Failed to decode id token claims error="json: Unmarshal(non-pointer headscale.IDTokenClaims)" ``` Is this related to the changed line in oidc.go? ``` if err := idToken.Claims(claims); err != nil { ``` **To Reproduce** Have a user log out of the tailscale client then reauthenticate, using Azure AD OIDC. When the browser window opens it will attempt to auth via AAD and fail with the above error. **Context info** Headscale version 0.16.2. tailscale client version 1.28.0
adam added the bug label 2025-12-29 01:26:34 +01:00
adam closed this issue 2025-12-29 01:26:35 +01:00
adam commented 2025-12-29 01:26:35 +01:00
Author
Owner
Copy Link

@mannp commented on GitHub (Aug 16, 2022):

Just had the same issue here with a previously working keycloak instance.

2022-08-16T14:03:08Z ERR go/src/headscale/oidc.go:324 > Failed to decode id token claims error="json: Unmarshal(non-pointer headscale.IDTokenClaims)"

@mannp commented on GitHub (Aug 16, 2022): Just had the same issue here with a previously working keycloak instance. `2022-08-16T14:03:08Z ERR go/src/headscale/oidc.go:324 > Failed to decode id token claims error="json: Unmarshal(non-pointer headscale.IDTokenClaims)"`
adam commented 2025-12-29 01:26:35 +01:00
Author
Owner
Copy Link

@victorhooi commented on GitHub (Aug 17, 2022):

Yup, I have the same issue as well on 0.16.2, and am getting the same error message.

I'm using OIDC with Google OAuth.

Is there some workaround we can use for now, or is this relatively easy to patch?

@victorhooi commented on GitHub (Aug 17, 2022): Yup, I have the same issue as well on 0.16.2, and am getting the same error message. I'm using OIDC with Google OAuth. Is there some workaround we can use for now, or is this relatively easy to patch?
adam commented 2025-12-29 01:26:35 +01:00
Author
Owner
Copy Link

@mannp commented on GitHub (Aug 17, 2022):

I went back to 0.16.1 and did have the same error, so went back to 0.16.0 and was able to login correctly.

@mannp commented on GitHub (Aug 17, 2022): I went back to 0.16.1 and did have the same error, so went back to 0.16.0 and was able to login correctly.
adam commented 2025-12-29 01:26:36 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Aug 17, 2022):

Hey people, we have merged a fix in main already.

Can you give a try before we release 0.16.3?

@juanfont commented on GitHub (Aug 17, 2022): Hey people, we have merged a fix in main already. Can you give a try before we release 0.16.3?
adam commented 2025-12-29 01:26:36 +01:00
Author
Owner
Copy Link

@victorhooi commented on GitHub (Aug 17, 2022):

I'm willing to try - is there a place we can download latest built binaries? (AMD64 in my case).

@victorhooi commented on GitHub (Aug 17, 2022): I'm willing to try - is there a place we can download latest built binaries? (AMD64 in my case).
adam commented 2025-12-29 01:26:36 +01:00
Author
Owner
Copy Link

@mannp commented on GitHub (Aug 17, 2022):

Still using docker and some Kubernetes for all of my infra, so not so easy to try without a pre-release docker img (which I appreciate is a hassle to create each time).

@mannp commented on GitHub (Aug 17, 2022): > Still using docker and some Kubernetes for all of my infra, so not so easy to try without a pre-release docker img (which I appreciate is a hassle to create each time).
adam commented 2025-12-29 01:26:36 +01:00
Author
Owner
Copy Link

@kyhwana commented on GitHub (Aug 18, 2022):

I built the main repo and updated.
When logging a user out (windows client) and then logging back in via oidc azure AD, I get the error
Aug 18 09:49:46 <headscalehost> headscale[1601506]: 2022-08-17T21:49:46Z DBG Machine registration has expired. Sending a authurl to register machine=<machine name>
Deleting the machine (which headscale nodes list says is expired?) and then reauthenticating works OK.

@kyhwana commented on GitHub (Aug 18, 2022): I built the main repo and updated. When logging a user out (windows client) and then logging back in via oidc azure AD, I get the error ```Aug 18 09:49:46 <headscalehost> headscale[1601506]: 2022-08-17T21:49:46Z DBG Machine registration has expired. Sending a authurl to register machine=<machine name>``` Deleting the machine (which headscale nodes list says is expired?) and then reauthenticating works OK.
adam commented 2025-12-29 01:26:37 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Aug 18, 2022):

@kyhwana thanks for checking out. I will close this issue and open a new one on the registration.

@juanfont commented on GitHub (Aug 18, 2022): @kyhwana thanks for checking out. I will close this issue and open a new one on the registration.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?