starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #312] [MERGED] poll: fix swapped machine<->namespace labels #1375

New Issue
Closed
opened 2025-12-29 02:29:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/312
Author: @hdhoang
Created: 2/11/2022
Status: ✅ Merged
Merged: 2/12/2022
Merged by: @kradalby

Base: main ← Head: patch-1

📝 Commits (3)

  • 150652e poll: fix swapped machine<->namespace labels
  • 66ff34c apply changelog
  • 20991d6 Merge branch 'main' into patch-1

📊 Changes

2 files changed (+7 additions, -6 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 poll.go (+6 -6)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Hi, we noticed label mismatches in update_request_* metrics:

# correct
headscale_last_update_seconds{machine="router1",namespace="routers"} 1.644561297e+09
headscale_last_update_seconds{machine="router2",namespace="routers"} 1.644561296e+09

# swapped labels
headscale_update_request_from_node_total{machine="routers",namespace="router1",state="endpoint-update"} 47
headscale_update_request_from_node_total{machine="routers",namespace="router1",state="full-update"} 26
headscale_update_request_from_node_total{machine="routers",namespace="router1",state="scheduled-update"} 1096
headscale_update_request_from_node_total{machine="routers",namespace="router2",state="endpoint-update"} 4
headscale_update_request_from_node_total{machine="routers",namespace="router2",state="full-update"} 2
headscale_update_request_from_node_total{machine="routers",namespace="router2",state="scheduled-update"} 1058

Hope this helps!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/312 **Author:** [@hdhoang](https://github.com/hdhoang) **Created:** 2/11/2022 **Status:** ✅ Merged **Merged:** 2/12/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`150652e`](https://github.com/juanfont/headscale/commit/150652e939dc383619cd112673f3f18d12d3ee10) poll: fix swapped machine<->namespace labels - [`66ff34c`](https://github.com/juanfont/headscale/commit/66ff34c2ddb2ca34dcee3a3aa49b14754aeb0591) apply changelog - [`20991d6`](https://github.com/juanfont/headscale/commit/20991d6883d42960c1e4943500af85b77bc26c71) Merge branch 'main' into patch-1 ### 📊 Changes **2 files changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `poll.go` (+6 -6) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Hi, we noticed label mismatches in `update_request_*` metrics: ```text # correct headscale_last_update_seconds{machine="router1",namespace="routers"} 1.644561297e+09 headscale_last_update_seconds{machine="router2",namespace="routers"} 1.644561296e+09 # swapped labels headscale_update_request_from_node_total{machine="routers",namespace="router1",state="endpoint-update"} 47 headscale_update_request_from_node_total{machine="routers",namespace="router1",state="full-update"} 26 headscale_update_request_from_node_total{machine="routers",namespace="router1",state="scheduled-update"} 1096 headscale_update_request_from_node_total{machine="routers",namespace="router2",state="endpoint-update"} 4 headscale_update_request_from_node_total{machine="routers",namespace="router2",state="full-update"} 2 headscale_update_request_from_node_total{machine="routers",namespace="router2",state="scheduled-update"} 1058 ``` Hope this helps! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:52 +01:00
adam closed this issue 2025-12-29 02:29:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?