starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2832] [MERGED] templates: migrate OIDC callback to elem-go, give an overhaul #2887

New Issue
Closed
opened 2025-12-29 04:19:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2832
Author: @kradalby
Created: 10/28/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @kradalby

Base: main ← Head: kradalby/goelem-oidc

📝 Commits (9)

  • 16d7fbd templates: migrate OIDC callback to elem-go
  • 6e9cdfb hscontrol/templates: add Material for MkDocs design assets
  • d9245bd hscontrol/templates: refactor to use CSS classes and embedded files
  • 7cc3402 hscontrol: add template HTML consistency test
  • 0da7758 hscontrol: use octal literal syntax in test
  • e2c33fd changelog: add entry for templates redesign
  • af71996 flake: disable CGO in dev shell
  • 80525a9 hscontrol: convert BlankHandler to use elem-go
  • 41187a8 hscontrol: consolidate assets into single package

📊 Changes

16 files changed (+1306 additions, -531 deletions)

View changed files

📝 CHANGELOG.md (+8 -0)
📝 flake.nix (+1 -0)
➕ hscontrol/assets/assets.go (+24 -0)
➕ hscontrol/assets/headscale.svg (+1 -0)
➖ hscontrol/assets/oidc_callback_template.html (+0 -307)
➕ hscontrol/assets/style.css (+147 -0)
📝 hscontrol/handlers.go (+12 -11)
📝 hscontrol/oidc.go (+3 -20)
➕ hscontrol/oidc_template_test.go (+63 -0)
📝 hscontrol/templates/apple.go (+92 -134)
➕ hscontrol/templates/design.go (+482 -0)
📝 hscontrol/templates/general.go (+175 -19)
➕ hscontrol/templates/oidc_callback.go (+69 -0)
📝 hscontrol/templates/register_web.go (+6 -20)
📝 hscontrol/templates/windows.go (+10 -20)
➕ hscontrol/templates_consistency_test.go (+213 -0)

📄 Description

apple_desktop oidc_callback_desktop

Closes #2115

claude was used in this PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2832 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/goelem-oidc` --- ### 📝 Commits (9) - [`16d7fbd`](https://github.com/juanfont/headscale/commit/16d7fbd97d81edff7768492b21d6667263cc840c) templates: migrate OIDC callback to elem-go - [`6e9cdfb`](https://github.com/juanfont/headscale/commit/6e9cdfbe22490011fd473fc1ffe18e0fa775ae89) hscontrol/templates: add Material for MkDocs design assets - [`d9245bd`](https://github.com/juanfont/headscale/commit/d9245bd2f5330074229a7712b5ac4822f8af263b) hscontrol/templates: refactor to use CSS classes and embedded files - [`7cc3402`](https://github.com/juanfont/headscale/commit/7cc3402b4cbbefabf924e85f4f1906af2a8ad11b) hscontrol: add template HTML consistency test - [`0da7758`](https://github.com/juanfont/headscale/commit/0da775888a5712a6334dc7d999cb74a756badb9d) hscontrol: use octal literal syntax in test - [`e2c33fd`](https://github.com/juanfont/headscale/commit/e2c33fd1febe1ebe894bbdf6b460008f65ab91c0) changelog: add entry for templates redesign - [`af71996`](https://github.com/juanfont/headscale/commit/af71996e26662ee384f1acd35893faa63648fc38) flake: disable CGO in dev shell - [`80525a9`](https://github.com/juanfont/headscale/commit/80525a94e4899fe5b9ca41ece9c1a029514f01c2) hscontrol: convert BlankHandler to use elem-go - [`41187a8`](https://github.com/juanfont/headscale/commit/41187a8f415d4e565e739ca5ec7332dd750fc751) hscontrol: consolidate assets into single package ### 📊 Changes **16 files changed** (+1306 additions, -531 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+8 -0) 📝 `flake.nix` (+1 -0) ➕ `hscontrol/assets/assets.go` (+24 -0) ➕ `hscontrol/assets/headscale.svg` (+1 -0) ➖ `hscontrol/assets/oidc_callback_template.html` (+0 -307) ➕ `hscontrol/assets/style.css` (+147 -0) 📝 `hscontrol/handlers.go` (+12 -11) 📝 `hscontrol/oidc.go` (+3 -20) ➕ `hscontrol/oidc_template_test.go` (+63 -0) 📝 `hscontrol/templates/apple.go` (+92 -134) ➕ `hscontrol/templates/design.go` (+482 -0) 📝 `hscontrol/templates/general.go` (+175 -19) ➕ `hscontrol/templates/oidc_callback.go` (+69 -0) 📝 `hscontrol/templates/register_web.go` (+6 -20) 📝 `hscontrol/templates/windows.go` (+10 -20) ➕ `hscontrol/templates_consistency_test.go` (+213 -0) </details> ### 📄 Description <img width="1920" height="1280" alt="apple_desktop" src="https://github.com/user-attachments/assets/4c7644f9-d2c4-4eca-a771-b9d26bb635ff" /> <img width="1920" height="1280" alt="oidc_callback_desktop" src="https://github.com/user-attachments/assets/dec831d0-42ff-4b74-b72b-dabb26c908e2" /> Closes #2115 claude was used in this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:31 +01:00
adam closed this issue 2025-12-29 04:19:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2887
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?