[PR #2745] [MERGED] Refactor to use reflect.TypeFor #2832

Closed
opened 2025-12-29 04:19:14 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2745
Author: @cuiweixie
Created: 8/23/2025
Status: Merged
Merged: 8/23/2025
Merged by: @nblock

Base: mainHead: reflect.TypeFor


📝 Commits (1)

  • eb6d80e Refactor to use reflect.TypeFor

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hscontrol/db/text_serialiser.go (+1 -1)

📄 Description

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2745 **Author:** [@cuiweixie](https://github.com/cuiweixie) **Created:** 8/23/2025 **Status:** ✅ Merged **Merged:** 8/23/2025 **Merged by:** [@nblock](https://github.com/nblock) **Base:** `main` ← **Head:** `reflect.TypeFor` --- ### 📝 Commits (1) - [`eb6d80e`](https://github.com/juanfont/headscale/commit/eb6d80ec18b249ec93071388b65b575ea79080ff) Refactor to use reflect.TypeFor ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/text_serialiser.go` (+1 -1) </details> ### 📄 Description <!-- Headscale is "Open Source, acknowledged contribution", this means that any contribution will have to be discussed with the Maintainers before being submitted. This model has been chosen to reduce the risk of burnout by limiting the maintenance overhead of reviewing and validating third-party code. Headscale is open to code contributions for bug fixes without discussion. If you find mistakes in the documentation, please submit a fix to the documentation. --> <!-- Please tick if the following things apply. You… --> - [ ] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:14 +01:00
adam closed this issue 2025-12-29 04:19:14 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2832