starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2544] [MERGED] config: disallow same server url and base_domain #2716

New Issue
Closed
opened 2025-12-29 03:22:28 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2544
Author: @kradalby
Created: 4/23/2025
Status: ✅ Merged
Merged: 4/23/2025
Merged by: @kradalby

Base: main ← Head: kradalby/2354-strict-base

📝 Commits (2)

  • 7b4fa45 config: disallow same server url and base_domain
  • b40981d changelog

📊 Changes

3 files changed (+11 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+5 -0)
📝 hscontrol/types/config.go (+5 -0)
📝 hscontrol/types/config_test.go (+1 -0)

📄 Description

Remove a footgun.

Fixes #2354

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2544 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/23/2025 **Status:** ✅ Merged **Merged:** 4/23/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2354-strict-base` --- ### 📝 Commits (2) - [`7b4fa45`](https://github.com/juanfont/headscale/commit/7b4fa455096e7cc377de84a998e473e9dbee9c37) config: disallow same server url and base_domain - [`b40981d`](https://github.com/juanfont/headscale/commit/b40981d9cbbb914a9cbb1a96cef020f69c3eb3e5) changelog ### 📊 Changes **3 files changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -0) 📝 `hscontrol/types/config.go` (+5 -0) 📝 `hscontrol/types/config_test.go` (+1 -0) </details> ### 📄 Description Remove a footgun. Fixes #2354 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:28 +01:00
adam closed this issue 2025-12-29 03:22:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2716
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?