starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2199] [MERGED] #2140 Fixed reflection of hostname change #2544

New Issue
Closed
opened 2025-12-29 03:21:44 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2199
Author: @hopleus
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @kradalby

Base: main ← Head: hotfix/2140-update-hostname

📝 Commits (4)

  • 22c8dd6 #2140 Fixed updating of hostname and givenName when it is updated in HostInfo
  • 7345d64 #2140 Added integration tests
  • f38a567 #2140 Fix unit tests
  • 37b0673 Changed IsAutomaticNameMode to GivenNameHasBeenChanged. Fixed errors in files according to golangci-lint rules

📊 Changes

6 files changed (+221 additions, -2 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+1 -0)
📝 CHANGELOG.md (+1 -0)
📝 hscontrol/poll.go (+9 -2)
📝 hscontrol/types/node.go (+20 -0)
📝 hscontrol/types/node_test.go (+60 -0)
📝 integration/general_test.go (+130 -0)

📄 Description

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #2140

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2199 **Author:** [@hopleus](https://github.com/hopleus) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `hotfix/2140-update-hostname` --- ### 📝 Commits (4) - [`22c8dd6`](https://github.com/juanfont/headscale/commit/22c8dd6ba47bee47d4163303dde85106989fc631) #2140 Fixed updating of hostname and givenName when it is updated in HostInfo - [`7345d64`](https://github.com/juanfont/headscale/commit/7345d647ca1cf32f2d78e82900818a6af66e90e7) #2140 Added integration tests - [`f38a567`](https://github.com/juanfont/headscale/commit/f38a56700370d7bd018c7add09906addc0aa15d8) #2140 Fix unit tests - [`37b0673`](https://github.com/juanfont/headscale/commit/37b067343778fa3bfa8c5b0d180fdc1683f9b879) Changed IsAutomaticNameMode to GivenNameHasBeenChanged. Fixed errors in files according to golangci-lint rules ### 📊 Changes **6 files changed** (+221 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+1 -0) 📝 `CHANGELOG.md` (+1 -0) 📝 `hscontrol/poll.go` (+9 -2) 📝 `hscontrol/types/node.go` (+20 -0) 📝 `hscontrol/types/node_test.go` (+60 -0) 📝 `integration/general_test.go` (+130 -0) </details> ### 📄 Description - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md Fixes #2140 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:44 +01:00
adam closed this issue 2025-12-29 03:21:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2544
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?