starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2435] [MERGED] handle register auth errors #2665

New Issue
Closed
opened 2025-12-29 03:22:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2435
Author: @kradalby
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/23/2025
Merged by: @kradalby

Base: main ← Head: kradalby/reg-auth-errs

📝 Commits (2)

📊 Changes

3 files changed (+132 additions, -30 deletions)

View changed files

📝 CHANGELOG.md (+7 -0)
📝 hscontrol/noise.go (+29 -30)
📝 integration/auth_key_test.go (+96 -0)

📄 Description

This commit handles register auth errors as the
Tailscale clients expect. It returns the error as
part of a tailcfg.RegisterResponse and not as a
http error.

In addition it fixes a nil pointer panic triggered by not handling the errors as part of this chain.

Fixes #2434

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2435 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/23/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/reg-auth-errs` --- ### 📝 Commits (2) - [`4aeee17`](https://github.com/juanfont/headscale/commit/4aeee171e200ef8a54910bbced4b1883946b4a81) handle register auth errors - [`e695d96`](https://github.com/juanfont/headscale/commit/e695d9665bbcc564fc6735b9f088ce7095e51890) changelog ### 📊 Changes **3 files changed** (+132 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+7 -0) 📝 `hscontrol/noise.go` (+29 -30) 📝 `integration/auth_key_test.go` (+96 -0) </details> ### 📄 Description This commit handles register auth errors as the Tailscale clients expect. It returns the error as part of a tailcfg.RegisterResponse and not as a http error. In addition it fixes a nil pointer panic triggered by not handling the errors as part of this chain. Fixes #2434 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:16 +01:00
adam closed this issue 2025-12-29 03:22:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?