starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1989] [MERGED] Remove allocations of lists before use #2435

New Issue
Closed
opened 2025-12-29 03:21:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1989
Author: @kradalby
Created: 6/20/2024
Status: ✅ Merged
Merged: 6/23/2024
Merged by: @kradalby

Base: main ← Head: kradalby/reduce-allocs

📝 Commits (3)

  • 3179191 policy: remove allocs before appends in acls
  • a2299e2 notifier: make batcher tests stable/non-flaky
  • ab7ab00 {db,derp,mapper}: dont allocate until append

📊 Changes

7 files changed (+46 additions, -32 deletions)

View changed files

📝 hscontrol/db/node.go (+3 -3)
📝 hscontrol/db/routes.go (+2 -2)
📝 hscontrol/derp/derp.go (+1 -1)
📝 hscontrol/mapper/mapper.go (+1 -1)
📝 hscontrol/notifier/notifier_test.go (+16 -0)
📝 hscontrol/policy/acls.go (+19 -21)
📝 hscontrol/policy/acls_test.go (+4 -4)

📄 Description

Remove the allocation of lists before they are used.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1989 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 6/23/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/reduce-allocs` --- ### 📝 Commits (3) - [`3179191`](https://github.com/juanfont/headscale/commit/317919151eb6bda75049230eb8e6b80cf0f1a176) policy: remove allocs before appends in acls - [`a2299e2`](https://github.com/juanfont/headscale/commit/a2299e2bccb08349298e61b30db798e14885cce0) notifier: make batcher tests stable/non-flaky - [`ab7ab00`](https://github.com/juanfont/headscale/commit/ab7ab0051b601586baf38ddeafa29a1e2300ea2f) {db,derp,mapper}: dont allocate until append ### 📊 Changes **7 files changed** (+46 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/node.go` (+3 -3) 📝 `hscontrol/db/routes.go` (+2 -2) 📝 `hscontrol/derp/derp.go` (+1 -1) 📝 `hscontrol/mapper/mapper.go` (+1 -1) 📝 `hscontrol/notifier/notifier_test.go` (+16 -0) 📝 `hscontrol/policy/acls.go` (+19 -21) 📝 `hscontrol/policy/acls_test.go` (+4 -4) </details> ### 📄 Description Remove the allocation of lists before they are used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:16 +01:00
adam closed this issue 2025-12-29 03:21:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2435
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?