starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2388] [MERGED] simplify findUserByToken in ACL, add missing testcases #2638

New Issue
Closed
opened 2025-12-29 03:22:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2388
Author: @kradalby
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @kradalby

Base: main ← Head: kradalby/find-user-token-test

📝 Commits (4)

  • 86662dd update users doc on unique constraints
  • 7084086 simplify finduser func
  • d9e575f add initial tests for findUserFromToken
  • 209093f add changelog

📊 Changes

4 files changed (+340 additions, -23 deletions)

View changed files

📝 CHANGELOG.md (+8 -1)
📝 hscontrol/policy/acls.go (+13 -18)
📝 hscontrol/policy/acls_test.go (+312 -0)
📝 hscontrol/types/users.go (+7 -4)

📄 Description

simplify findUserByToken in ACL, add missing testcases

Fixes #2377

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2388 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/find-user-token-test` --- ### 📝 Commits (4) - [`86662dd`](https://github.com/juanfont/headscale/commit/86662dd73e0d2cd817b1335ec258daf5d0967e25) update users doc on unique constraints - [`7084086`](https://github.com/juanfont/headscale/commit/7084086498b7221d7102092cc5298d99b3626f44) simplify finduser func - [`d9e575f`](https://github.com/juanfont/headscale/commit/d9e575f1c5b3b145605c412517e726724a8f4e8d) add initial tests for findUserFromToken - [`209093f`](https://github.com/juanfont/headscale/commit/209093f5ab3b143b82b68abc81706f3a7af07211) add changelog ### 📊 Changes **4 files changed** (+340 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+8 -1) 📝 `hscontrol/policy/acls.go` (+13 -18) 📝 `hscontrol/policy/acls_test.go` (+312 -0) 📝 `hscontrol/types/users.go` (+7 -4) </details> ### 📄 Description simplify findUserByToken in ACL, add missing testcases Fixes #2377 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:09 +01:00
adam closed this issue 2025-12-29 03:22:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2638
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?