starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1904] [CLOSED] try to close on existing connection, also reject #2388

New Issue
Closed
opened 2025-12-29 03:21:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1904
Author: @kradalby
Created: 4/22/2024
Status: ❌ Closed

Base: main ← Head: kradalby/close-and-reject

📝 Commits (10+)

  • d79f621 try to close on existing connection, also reject
  • 6832a3e add gauge metrics for waiting for notifier lock
  • a41a343 add gauge metrics for waiting for notifier batcher lock
  • 57203db add gauge metrics for current pending updates
  • ae065c8 add metric and count to String method
  • cf967f9 add timeout to sendall
  • 4939c18 count mapresps ended
  • 46feed8 count mapresps ended
  • 1e08975 correct metrics
  • 921f55f add metric for tracking mapresp.close returns

📊 Changes

9 files changed (+229 additions, -127 deletions)

View changed files

📝 hscontrol/app.go (+1 -3)
📝 hscontrol/derp/server/derp_server.go (+1 -1)
📝 hscontrol/metrics.go (+13 -3)
📝 hscontrol/noise.go (+45 -49)
📝 hscontrol/notifier/metrics.go (+21 -1)
📝 hscontrol/notifier/notifier.go (+53 -29)
📝 hscontrol/poll.go (+87 -41)
📝 hscontrol/types/common.go (+4 -0)
📝 hscontrol/types/node.go (+4 -0)

📄 Description

nothing to see, trying to figure out the correct way to handle this.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1904 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/22/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kradalby/close-and-reject` --- ### 📝 Commits (10+) - [`d79f621`](https://github.com/juanfont/headscale/commit/d79f621e3a83a84ef08b399481e0dd2bf06fbed2) try to close on existing connection, also reject - [`6832a3e`](https://github.com/juanfont/headscale/commit/6832a3e9bf51c80619e4b1f87329973a9ce5df1a) add gauge metrics for waiting for notifier lock - [`a41a343`](https://github.com/juanfont/headscale/commit/a41a3437e2a2346327992407a149a6627184a930) add gauge metrics for waiting for notifier batcher lock - [`57203db`](https://github.com/juanfont/headscale/commit/57203db60eb62f2e6977f1f900cbc55815c01ebf) add gauge metrics for current pending updates - [`ae065c8`](https://github.com/juanfont/headscale/commit/ae065c8f3eefc9c590d96391fe38080d5df89659) add metric and count to String method - [`cf967f9`](https://github.com/juanfont/headscale/commit/cf967f98395868c5debfe6bc4f86e39562ff662c) add timeout to sendall - [`4939c18`](https://github.com/juanfont/headscale/commit/4939c18668b1b7ffa37ae636d3bf228b062514b4) count mapresps ended - [`46feed8`](https://github.com/juanfont/headscale/commit/46feed84d91cb896f06fc9b831d34fa68796a870) count mapresps ended - [`1e08975`](https://github.com/juanfont/headscale/commit/1e089757a802902a00d95d3fb8848ef629dadf7b) correct metrics - [`921f55f`](https://github.com/juanfont/headscale/commit/921f55fed2a1f959295a719065228fbf4ffb1c01) add metric for tracking mapresp.close returns ### 📊 Changes **9 files changed** (+229 additions, -127 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/app.go` (+1 -3) 📝 `hscontrol/derp/server/derp_server.go` (+1 -1) 📝 `hscontrol/metrics.go` (+13 -3) 📝 `hscontrol/noise.go` (+45 -49) 📝 `hscontrol/notifier/metrics.go` (+21 -1) 📝 `hscontrol/notifier/notifier.go` (+53 -29) 📝 `hscontrol/poll.go` (+87 -41) 📝 `hscontrol/types/common.go` (+4 -0) 📝 `hscontrol/types/node.go` (+4 -0) </details> ### 📄 Description nothing to see, trying to figure out the correct way to handle this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:01 +01:00
adam closed this issue 2025-12-29 03:21:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?