[PR #2328] [MERGED] Set CSRF cookies for OIDC #2607

Closed
opened 2025-12-29 03:22:00 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2328
Author: @kradalby
Created: 1/6/2025
Status: Merged
Merged: 1/8/2025
Merged by: @kradalby

Base: mainHead: kradalby/oidc-csrf


📝 Commits (2)

  • 60f71be set state and nounce in oidc to prevent csrf
  • 3dd22d7 try to fix new postgres issue

📊 Changes

3 files changed (+100 additions, -21 deletions)

View changed files

📝 .github/workflows/test.yml (+6 -0)
📝 hscontrol/oidc.go (+54 -7)
📝 integration/auth_oidc_test.go (+40 -14)

📄 Description

Fixes #2276


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2328 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/oidc-csrf` --- ### 📝 Commits (2) - [`60f71be`](https://github.com/juanfont/headscale/commit/60f71beffba0e2287702941e26978fe34589b275) set state and nounce in oidc to prevent csrf - [`3dd22d7`](https://github.com/juanfont/headscale/commit/3dd22d75a4baf7811c235a9963532d9e923d69f8) try to fix new postgres issue ### 📊 Changes **3 files changed** (+100 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+6 -0) 📝 `hscontrol/oidc.go` (+54 -7) 📝 `integration/auth_oidc_test.go` (+40 -14) </details> ### 📄 Description Fixes #2276 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:00 +01:00
adam closed this issue 2025-12-29 03:22:01 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2607