starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1729] [MERGED] Get integration test netmap from watch-ipn command #2276

New Issue
Closed
opened 2025-12-29 03:20:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1729
Author: @kradalby
Created: 2/9/2024
Status: ✅ Merged
Merged: 2/18/2024
Merged by: @kradalby

Base: main ← Head: netmap-from-watch-ipn

📝 Commits (2)

  • a89eb6d add version comparer helper
  • e0d4006 replace netmap implementation

📊 Changes

6 files changed (+244 additions, -35 deletions)

View changed files

📝 hscontrol/poll.go (+2 -8)
➕ hscontrol/util/util.go (+13 -0)
➕ hscontrol/util/util_test.go (+95 -0)
📝 integration/embedded_derp_test.go (+0 -2)
📝 integration/tsic/tsic.go (+112 -14)
📝 integration/utils.go (+22 -11)

📄 Description

This version uses tailscale debug watch-ipn as
it is available in all supported versions, and it
does not seem to have any weird side effect when using
Patch updates (empty values).

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1729 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/9/2024 **Status:** ✅ Merged **Merged:** 2/18/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `netmap-from-watch-ipn` --- ### 📝 Commits (2) - [`a89eb6d`](https://github.com/juanfont/headscale/commit/a89eb6defa534de7b74dcbd48cadcab885a06adb) add version comparer helper - [`e0d4006`](https://github.com/juanfont/headscale/commit/e0d400632aa66bf844daf86f98b67c6c879e2bb9) replace netmap implementation ### 📊 Changes **6 files changed** (+244 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/poll.go` (+2 -8) ➕ `hscontrol/util/util.go` (+13 -0) ➕ `hscontrol/util/util_test.go` (+95 -0) 📝 `integration/embedded_derp_test.go` (+0 -2) 📝 `integration/tsic/tsic.go` (+112 -14) 📝 `integration/utils.go` (+22 -11) </details> ### 📄 Description This version uses `tailscale debug watch-ipn` as it is available in all supported versions, and it does not seem to have any weird side effect when using Patch updates (empty values). Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:31 +01:00
adam closed this issue 2025-12-29 03:20:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2276
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?