starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2298] [MERGED] fixes to extra-record file watcher #2594

New Issue
Closed
opened 2025-12-29 03:21:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2298
Author: @kradalby
Created: 12/15/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @kradalby

Base: main ← Head: kradalby/dns-extra-record-fix

📝 Commits (3)

  • 443f461 Fix excess error message during writes
  • f0c6790 retry filewatcher on removed files
  • 88a9ba6 test more write and remove in filewatcher

📊 Changes

2 files changed (+120 additions, -11 deletions)

View changed files

📝 hscontrol/dns/extrarecords.go (+44 -5)
📝 integration/dns_test.go (+76 -6)

📄 Description

Fixes #2290
Fixes #2289

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2298 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/15/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/dns-extra-record-fix` --- ### 📝 Commits (3) - [`443f461`](https://github.com/juanfont/headscale/commit/443f461be9aa69c0851dac26c751553ed04ed87b) Fix excess error message during writes - [`f0c6790`](https://github.com/juanfont/headscale/commit/f0c67904144d017f229d753ed1ced104765481fe) retry filewatcher on removed files - [`88a9ba6`](https://github.com/juanfont/headscale/commit/88a9ba657ebf25e956de7eacc445847de7e0e318) test more write and remove in filewatcher ### 📊 Changes **2 files changed** (+120 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/dns/extrarecords.go` (+44 -5) 📝 `integration/dns_test.go` (+76 -6) </details> ### 📄 Description Fixes #2290 Fixes #2289 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:57 +01:00
adam closed this issue 2025-12-29 03:21:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2594
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?