starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1754] [MERGED] drop unused last_successful_update field from node table #2298

New Issue
Closed
opened 2025-12-29 03:20:36 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1754
Author: @kradalby
Created: 2/15/2024
Status: ✅ Merged
Merged: 2/18/2024
Merged by: @kradalby

Base: main ← Head: remove-last-success

📝 Commits (5)

  • bfa1490 update grpc-gateway
  • 5ca2a40 remove unused last_successful_update field
  • 4317d61 generate and format
  • 7ccd140 drop last_successful_update column from db
  • d26a83f add comment about removed number

📊 Changes

16 files changed (+386 additions, -402 deletions)

View changed files

📝 flake.nix (+3 -3)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+15 -71)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+82 -53)
📝 gen/go/headscale/v1/node.pb.go (+140 -154)
📝 gen/openapiv2/headscale/v1/apikey.swagger.json (+1 -0)
📝 gen/openapiv2/headscale/v1/device.swagger.json (+1 -0)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+19 -13)
📝 gen/openapiv2/headscale/v1/node.swagger.json (+1 -0)
📝 gen/openapiv2/headscale/v1/preauthkey.swagger.json (+1 -0)
📝 gen/openapiv2/headscale/v1/routes.swagger.json (+1 -0)
📝 gen/openapiv2/headscale/v1/user.swagger.json (+1 -0)
📝 hscontrol/db/db.go (+11 -0)
📝 proto/headscale/v1/headscale.proto (+85 -85)
📝 proto/headscale/v1/node.proto (+16 -14)
📝 proto/headscale/v1/preauthkey.proto (+3 -3)
📝 proto/headscale/v1/routes.proto (+6 -6)

📄 Description

This PR will drop last_successful_update from the node table and remove it (but keep it reserved) from grpc.

This should fix #1748 to some extent.

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1754 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/15/2024 **Status:** ✅ Merged **Merged:** 2/18/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `remove-last-success` --- ### 📝 Commits (5) - [`bfa1490`](https://github.com/juanfont/headscale/commit/bfa149097ff87bd42ae1fbe21da41c431d2ab2f2) update grpc-gateway - [`5ca2a40`](https://github.com/juanfont/headscale/commit/5ca2a403cd4a381af75f8d5196cf33b045946df1) remove unused last_successful_update field - [`4317d61`](https://github.com/juanfont/headscale/commit/4317d6145d288f356af8ce17faa44883ec3bc5df) generate and format - [`7ccd140`](https://github.com/juanfont/headscale/commit/7ccd140ec704a5632ab2b3c0a0102bc2eff9dc73) drop last_successful_update column from db - [`d26a83f`](https://github.com/juanfont/headscale/commit/d26a83f330093901adf8251fe00795a9d196d30e) add comment about removed number ### 📊 Changes **16 files changed** (+386 additions, -402 deletions) <details> <summary>View changed files</summary> 📝 `flake.nix` (+3 -3) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+15 -71) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+82 -53) 📝 `gen/go/headscale/v1/node.pb.go` (+140 -154) 📝 `gen/openapiv2/headscale/v1/apikey.swagger.json` (+1 -0) 📝 `gen/openapiv2/headscale/v1/device.swagger.json` (+1 -0) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+19 -13) 📝 `gen/openapiv2/headscale/v1/node.swagger.json` (+1 -0) 📝 `gen/openapiv2/headscale/v1/preauthkey.swagger.json` (+1 -0) 📝 `gen/openapiv2/headscale/v1/routes.swagger.json` (+1 -0) 📝 `gen/openapiv2/headscale/v1/user.swagger.json` (+1 -0) 📝 `hscontrol/db/db.go` (+11 -0) 📝 `proto/headscale/v1/headscale.proto` (+85 -85) 📝 `proto/headscale/v1/node.proto` (+16 -14) 📝 `proto/headscale/v1/preauthkey.proto` (+3 -3) 📝 `proto/headscale/v1/routes.proto` (+6 -6) </details> ### 📄 Description This PR will drop `last_successful_update` from the node table and remove it (but keep it reserved) from grpc. This should fix #1748 to some extent. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:36 +01:00
adam closed this issue 2025-12-29 03:20:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?