starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2131] [CLOSED] Fix nodes not getting set to offline when disconnects #2517

New Issue
Closed
opened 2025-12-29 03:21:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2131
Author: @kradalby
Created: 9/13/2024
Status: ❌ Closed

Base: main ← Head: kradalby/2129-disconnect-detect

📝 Commits (2)

📊 Changes

4 files changed (+287 additions, -29 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+1 -0)
📝 hscontrol/poll.go (+8 -29)
📝 integration/route_test.go (+250 -0)
📝 integration/scenario.go (+28 -0)

📄 Description

Fixes #2129

Summary by CodeRabbit

  • New Features

    • Introduced a new test case to enhance testing for subnet router failover during node disconnections.
    • Added functionality for disconnecting multiple containers from a network, improving test management.

  • Bug Fixes

    • Enhanced validation processes for system resilience under network disruptions.
    • Improved logging and error handling for long polling operations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2131 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 9/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kradalby/2129-disconnect-detect` --- ### 📝 Commits (2) - [`1ec99c5`](https://github.com/juanfont/headscale/commit/1ec99c55e4797311dd2edb633c7fc4364ef977ed) add test to reproduce #2129 - [`98a65c7`](https://github.com/juanfont/headscale/commit/98a65c76d33de75e8ef511b44dbb27b80d945fc5) flesh out tests ### 📊 Changes **4 files changed** (+287 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+1 -0) 📝 `hscontrol/poll.go` (+8 -29) 📝 `integration/route_test.go` (+250 -0) 📝 `integration/scenario.go` (+28 -0) </details> ### 📄 Description Fixes #2129 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new test case to enhance testing for subnet router failover during node disconnections. - Added functionality for disconnecting multiple containers from a network, improving test management. - **Bug Fixes** - Enhanced validation processes for system resilience under network disruptions. - Improved logging and error handling for long polling operations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:37 +01:00
adam closed this issue 2025-12-29 03:21:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2517
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?