starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1460] [CLOSED] Add sync errorgroup handling in integration tests #2131

New Issue
Closed
opened 2025-12-29 03:19:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1460
Author: @kev-the-dev
Created: 5/11/2023
Status: ❌ Closed

Base: main ← Head: kev-the-dev/integration-test-error-handeling

📝 Commits (1)

  • 39accdc Add sync errorgroup handling in integration tests

📊 Changes

6 files changed (+76 additions, -89 deletions)

View changed files

📝 integration/README.md (+1 -1)
📝 integration/auth_oidc_test.go (+14 -17)
📝 integration/auth_web_flow_test.go (+13 -11)
📝 integration/embedded_derp_test.go (+7 -14)
📝 integration/general_test.go (+6 -2)
📝 integration/scenario.go (+35 -44)

📄 Description

Address TODOs in integration tests to handle errors from sync WaitGroup for things like bringing up a bunch of tailscale nodes. I ran into some confusing segfaults when running integration tests locally that would be helped by implementing this fail-on-error rather than log-on-error.

Closes #1459

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md -> internal change, no changelog update

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1460 **Author:** [@kev-the-dev](https://github.com/kev-the-dev) **Created:** 5/11/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kev-the-dev/integration-test-error-handeling` --- ### 📝 Commits (1) - [`39accdc`](https://github.com/juanfont/headscale/commit/39accdc8a20ca84e77d6d7b3c21d3fdd9d1784a2) Add sync errorgroup handling in integration tests ### 📊 Changes **6 files changed** (+76 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `integration/README.md` (+1 -1) 📝 `integration/auth_oidc_test.go` (+14 -17) 📝 `integration/auth_web_flow_test.go` (+13 -11) 📝 `integration/embedded_derp_test.go` (+7 -14) 📝 `integration/general_test.go` (+6 -2) 📝 `integration/scenario.go` (+35 -44) </details> ### 📄 Description Address TODOs in integration tests to handle errors from sync WaitGroup for things like bringing up a bunch of tailscale nodes. I ran into some confusing segfaults when running integration tests locally that would be helped by implementing this fail-on-error rather than log-on-error. Closes #1459 - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added integration tests - [x] updated documentation if needed - [ ] updated CHANGELOG.md -> internal change, no changelog update --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:53 +01:00
adam closed this issue 2025-12-29 03:19:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?