starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1905] [MERGED] batch updates in notifier #2389

New Issue
Closed
opened 2025-12-29 03:21:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1905
Author: @kradalby
Created: 4/22/2024
Status: ✅ Merged
Merged: 4/27/2024
Merged by: @kradalby

Base: main ← Head: kradalby/notifier-batcher

📝 Commits (3)

  • ea127cc snapshot integration test metrics at the end of test
  • 8a4a6a1 shutdown hasubnet test
  • ecc0d5a batch updates in notifier, not poller

📊 Changes

8 files changed (+541 additions, -158 deletions)

View changed files

📝 hscontrol/app.go (+1 -1)
📝 hscontrol/notifier/metrics.go (+6 -1)
📝 hscontrol/notifier/notifier.go (+192 -14)
➕ hscontrol/notifier/notifier_test.go (+249 -0)
📝 hscontrol/poll.go (+55 -137)
📝 hscontrol/types/common.go (+9 -4)
📝 integration/hsic/hsic.go (+28 -0)
📝 integration/route_test.go (+1 -1)

📄 Description

This PR will move the batching and deduplication of node updates into the notifier, instead of the poller.

This saves a huge amount of traffic going between and removes quite a lot of unnecessary updates when nodes are connecting and informing us several times.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1905 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/22/2024 **Status:** ✅ Merged **Merged:** 4/27/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/notifier-batcher` --- ### 📝 Commits (3) - [`ea127cc`](https://github.com/juanfont/headscale/commit/ea127cc3fb93d62bf3a1ebb97fffd3fbd9ed261e) snapshot integration test metrics at the end of test - [`8a4a6a1`](https://github.com/juanfont/headscale/commit/8a4a6a13de3a8e075278c20906a0e4d7962e8f20) shutdown hasubnet test - [`ecc0d5a`](https://github.com/juanfont/headscale/commit/ecc0d5a3b468055662d6e7fb11c38c340b653da5) batch updates in notifier, not poller ### 📊 Changes **8 files changed** (+541 additions, -158 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/app.go` (+1 -1) 📝 `hscontrol/notifier/metrics.go` (+6 -1) 📝 `hscontrol/notifier/notifier.go` (+192 -14) ➕ `hscontrol/notifier/notifier_test.go` (+249 -0) 📝 `hscontrol/poll.go` (+55 -137) 📝 `hscontrol/types/common.go` (+9 -4) 📝 `integration/hsic/hsic.go` (+28 -0) 📝 `integration/route_test.go` (+1 -1) </details> ### 📄 Description This PR will move the batching and deduplication of node updates into the notifier, instead of the poller. This saves a huge amount of traffic going between and removes quite a lot of unnecessary updates when nodes are connecting and informing us several times. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:01 +01:00
adam closed this issue 2025-12-29 03:21:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?