starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1133] [MERGED] Refresh machines with correct new expiry #1905

New Issue
Closed
opened 2025-12-29 03:18:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:18:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1133
Author: @evenh
Created: 1/11/2023
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @juanfont

Base: main ← Head: fix-node-refresh-expiry

📝 Commits (2)

  • 9087ec3 Refresh machines with correct new expiry
  • 6422bc7 nodes list: expose expiration time

📊 Changes

3 files changed (+14 additions, -2 deletions)

View changed files

📝 cmd/headscale/cli/nodes.go (+6 -0)
📝 machine.go (+1 -0)
📝 oidc.go (+7 -2)

📄 Description

Whenever a machine should be refreshed, the new OIDC expiry time wouldn't be persisted. This PR adresses this critical bug. I've also expanded the nodes list command to show the expiration time.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1133 **Author:** [@evenh](https://github.com/evenh) **Created:** 1/11/2023 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-node-refresh-expiry` --- ### 📝 Commits (2) - [`9087ec3`](https://github.com/juanfont/headscale/commit/9087ec38b39ac3fa616d853138ab7ccb126b2d65) Refresh machines with correct new expiry - [`6422bc7`](https://github.com/juanfont/headscale/commit/6422bc7b25e01152e7ba6a1bb38d8d32c7fa85e7) nodes list: expose expiration time ### 📊 Changes **3 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/nodes.go` (+6 -0) 📝 `machine.go` (+1 -0) 📝 `oidc.go` (+7 -2) </details> ### 📄 Description Whenever a machine should be refreshed, the new OIDC expiry time wouldn't be persisted. This PR adresses this critical bug. I've also expanded the `nodes list` command to show the expiration time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:18:48 +01:00
adam closed this issue 2025-12-29 03:18:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?