starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1707] [MERGED] Fix failover to disabled route #1706 #2266

New Issue
Closed
opened 2025-12-29 03:20:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1707
Author: @derelm
Created: 1/31/2024
Status: ✅ Merged
Merged: 2/3/2024
Merged by: @kradalby

Base: main ← Head: fix-failover-to-disabled-route

📝 Commits (3)

  • d4d6ad6 fix #1706 - failover should disregard disabled routes during failover
  • 7c0ae63 fixe tests for failover; all current tests assume routes to be enabled
  • fdf2c99 add testcase for #1706 - failover to disabled route

📊 Changes

2 files changed (+62 additions, -0 deletions)

View changed files

📝 hscontrol/db/routes.go (+4 -0)
📝 hscontrol/db/routes_test.go (+58 -0)

📄 Description

Fixes #1706 by checking routes enabled state. This PR updates the existing tests and adds an additional test covering the bug. All existing tests were assuming routes to be enabled.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1707 **Author:** [@derelm](https://github.com/derelm) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 2/3/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix-failover-to-disabled-route` --- ### 📝 Commits (3) - [`d4d6ad6`](https://github.com/juanfont/headscale/commit/d4d6ad65c5e908a14f68b3ca3cf571aadd7d8ba2) fix #1706 - failover should disregard disabled routes during failover - [`7c0ae63`](https://github.com/juanfont/headscale/commit/7c0ae63a61c36655ca3eb3630f8c6f39cec89c89) fixe tests for failover; all current tests assume routes to be enabled - [`fdf2c99`](https://github.com/juanfont/headscale/commit/fdf2c99a004620018021adc9fe3569343d46f34a) add testcase for #1706 - failover to disabled route ### 📊 Changes **2 files changed** (+62 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/routes.go` (+4 -0) 📝 `hscontrol/db/routes_test.go` (+58 -0) </details> ### 📄 Description Fixes #1706 by checking routes enabled state. This PR updates the existing tests and adds an additional test covering the bug. All existing tests were assuming routes to be enabled. - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:29 +01:00
adam closed this issue 2025-12-29 03:20:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?