starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #880] [CLOSED] Add logging to file #1707

New Issue
Closed
opened 2025-12-29 02:31:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/880
Author: @joshuataylor
Created: 10/22/2022
Status: ❌ Closed

Base: main ← Head: feature/log-to-file

📝 Commits (2)

  • 4165d21 Add logging to file
  • 73102b9 Merge branch 'main' into feature/log-to-file

📊 Changes

3 files changed (+28 additions, -4 deletions)

View changed files

📝 cmd/headscale/cli/root.go (+14 -0)
📝 config-example.yaml (+2 -0)
📝 config.go (+12 -4)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #879

I'm very rusty with Go, so apologies for any blatant mistakes. Please feel free to edit/critique as needed. :).

The problem with this approach is that it either logs to file OR stdout etc. We should allow users to configure multiple log locations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/880 **Author:** [@joshuataylor](https://github.com/joshuataylor) **Created:** 10/22/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/log-to-file` --- ### 📝 Commits (2) - [`4165d21`](https://github.com/juanfont/headscale/commit/4165d21e6a7f4820a9d758400643d92b7d10e18b) Add logging to file - [`73102b9`](https://github.com/juanfont/headscale/commit/73102b91d64d7949cb061075cd803ad554d4f7b2) Merge branch 'main' into feature/log-to-file ### 📊 Changes **3 files changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/root.go` (+14 -0) 📝 `config-example.yaml` (+2 -0) 📝 `config.go` (+12 -4) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md Fixes #879 I'm very rusty with Go, so apologies for any blatant mistakes. Please feel free to edit/critique as needed. :). The problem with this approach is that it either logs to file OR stdout etc. We should allow users to configure multiple log locations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:21 +01:00
adam closed this issue 2025-12-29 02:31:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1707
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?