starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1617] [CLOSED] Allow setting ForcedTags using the acls.hujson config file #2214

New Issue
Closed
opened 2025-12-29 03:20:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1617
Author: @networkException
Created: 11/26/2023
Status: ❌ Closed

Base: main ← Head: recursive-declarative-forced-tags

📝 Commits (1)

  • 2bec0a3 Allow setting ForcedTags using the acls.hujson config file

📊 Changes

3 files changed (+47 additions, -0 deletions)

View changed files

📝 hscontrol/policy/acls.go (+9 -0)
📝 hscontrol/policy/acls_test.go (+34 -0)
📝 hscontrol/policy/acls_types.go (+4 -0)

📄 Description

This pull request introduces a declarative way to set ForcedTags on nodes by recursively expanding aliases. These declarative forced tags are considered separately from the ones stored in the database.

Continuation of #1490

{
    "hosts": {
        "a": "fd7a:115c:a1e0::1",
        "b": "fd7a:115c:a1e0::2"
    },
    "forcedTags": {
        "tag:some-tag": [
            "a",
            "tag:some-other-tag"
        ],
        "tag:some-other-tag": [
            "b"
        ]
    }
}
  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1617 **Author:** [@networkException](https://github.com/networkException) **Created:** 11/26/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `recursive-declarative-forced-tags` --- ### 📝 Commits (1) - [`2bec0a3`](https://github.com/juanfont/headscale/commit/2bec0a3dadae1500f3c3600900aecc2e8e0cb6b6) Allow setting ForcedTags using the acls.hujson config file ### 📊 Changes **3 files changed** (+47 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/policy/acls.go` (+9 -0) 📝 `hscontrol/policy/acls_test.go` (+34 -0) 📝 `hscontrol/policy/acls_types.go` (+4 -0) </details> ### 📄 Description This pull request introduces a declarative way to set `ForcedTags` on nodes by recursively expanding aliases. These declarative forced tags are considered separately from the ones stored in the database. Continuation of #1490 ```json { "hosts": { "a": "fd7a:115c:a1e0::1", "b": "fd7a:115c:a1e0::2" }, "forcedTags": { "tag:some-tag": [ "a", "tag:some-other-tag" ], "tag:some-other-tag": [ "b" ] } } ``` - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:15 +01:00
adam closed this issue 2025-12-29 03:20:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?