[PR #574] [MERGED] show ipv4 address first in node list #1490

Closed
opened 2025-12-29 02:30:16 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/574
Author: @deonthomasgy
Created: 5/8/2022
Status: Merged
Merged: 5/8/2022
Merged by: @juanfont

Base: mainHead: main


📝 Commits (2)

  • b4f5ed6 order ip address output, IPv4 first
  • 6ed79b7 order Ip Address, IPv4 first, cleanup

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 cmd/headscale/cli/nodes.go (+13 -1)

📄 Description

before
image

after
image

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/574 **Author:** [@deonthomasgy](https://github.com/deonthomasgy) **Created:** 5/8/2022 **Status:** ✅ Merged **Merged:** 5/8/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`b4f5ed6`](https://github.com/juanfont/headscale/commit/b4f5ed6618ea5e1cc62601ab4fd6b395e9db8b99) order ip address output, IPv4 first - [`6ed79b7`](https://github.com/juanfont/headscale/commit/6ed79b7bb8217547af814ec6761d0c45f72e35f9) order Ip Address, IPv4 first, cleanup ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/nodes.go` (+13 -1) </details> ### 📄 Description before ![image](https://user-images.githubusercontent.com/150036/167312664-03cc983e-028b-43a0-80f0-0dbdc4c54654.png) after ![image](https://user-images.githubusercontent.com/150036/167312667-d74c3209-1d7e-49d1-b377-e13663507b59.png) <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#user-content-contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:16 +01:00
adam closed this issue 2025-12-29 02:30:16 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1490