[PR #1609] [MERGED] Use tailscale key types instead of strings #2207

Closed
opened 2025-12-29 03:20:13 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1609
Author: @kradalby
Created: 11/17/2023
Status: Merged
Merged: 11/19/2023
Merged by: @kradalby

Base: mainHead: key-types


📝 Commits (8)

  • 9d95893 upgrade tailscale
  • 462dbee make Node object use actualy tailscale key types
  • d9e5b4a use key types throughout the code
  • 09954c1 make sure machinekey is concistently used
  • 9fdd234 use machine key in auth url
  • 7815324 fix web register
  • afdae07 use key type in notifier
  • 5aa03ea fix relogin with webauth

📊 Changes

22 files changed (+549 additions, -470 deletions)

View changed files

📝 cmd/headscale/cli/debug.go (+6 -4)
📝 flake.nix (+1 -1)
📝 go.mod (+34 -33)
📝 go.sum (+73 -69)
📝 hscontrol/app.go (+2 -2)
📝 hscontrol/auth.go (+17 -21)
📝 hscontrol/db/db.go (+48 -29)
📝 hscontrol/db/node.go (+28 -29)
📝 hscontrol/db/node_test.go (+53 -41)
📝 hscontrol/db/suite_test.go (+9 -5)
📝 hscontrol/grpcv1.go (+23 -10)
📝 hscontrol/handlers.go (+6 -24)
📝 hscontrol/mapper/mapper.go (+2 -13)
📝 hscontrol/mapper/mapper_test.go (+30 -14)
📝 hscontrol/mapper/tail.go (+9 -19)
📝 hscontrol/mapper/tail_test.go (+29 -10)
📝 hscontrol/notifier/notifier.go (+11 -10)
📝 hscontrol/oidc.go (+21 -35)
📝 hscontrol/policy/acls_test.go (+20 -18)
📝 hscontrol/poll.go (+10 -10)

...and 2 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1609 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/17/2023 **Status:** ✅ Merged **Merged:** 11/19/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `key-types` --- ### 📝 Commits (8) - [`9d95893`](https://github.com/juanfont/headscale/commit/9d9589363f8a0487b4ee0191cb80c04c031ce03c) upgrade tailscale - [`462dbee`](https://github.com/juanfont/headscale/commit/462dbeef7d20f1c4bb91c3b864014ec477b12373) make Node object use actualy tailscale key types - [`d9e5b4a`](https://github.com/juanfont/headscale/commit/d9e5b4ac423fb2e70073b41972ee1ab0ce19dd51) use key types throughout the code - [`09954c1`](https://github.com/juanfont/headscale/commit/09954c1be25fdf20a63ca1432c7f8bb05df074b4) make sure machinekey is concistently used - [`9fdd234`](https://github.com/juanfont/headscale/commit/9fdd2348cf9849112bb2a91f599dd6985ce5b4c2) use machine key in auth url - [`7815324`](https://github.com/juanfont/headscale/commit/78153242379ef5ab1c1e45688349a81cbdc5e5ab) fix web register - [`afdae07`](https://github.com/juanfont/headscale/commit/afdae0742874a7cc16f62d9e52dc0c537835cbf9) use key type in notifier - [`5aa03ea`](https://github.com/juanfont/headscale/commit/5aa03ea4963819b1a67548b4c095606d9c4a0a0f) fix relogin with webauth ### 📊 Changes **22 files changed** (+549 additions, -470 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/debug.go` (+6 -4) 📝 `flake.nix` (+1 -1) 📝 `go.mod` (+34 -33) 📝 `go.sum` (+73 -69) 📝 `hscontrol/app.go` (+2 -2) 📝 `hscontrol/auth.go` (+17 -21) 📝 `hscontrol/db/db.go` (+48 -29) 📝 `hscontrol/db/node.go` (+28 -29) 📝 `hscontrol/db/node_test.go` (+53 -41) 📝 `hscontrol/db/suite_test.go` (+9 -5) 📝 `hscontrol/grpcv1.go` (+23 -10) 📝 `hscontrol/handlers.go` (+6 -24) 📝 `hscontrol/mapper/mapper.go` (+2 -13) 📝 `hscontrol/mapper/mapper_test.go` (+30 -14) 📝 `hscontrol/mapper/tail.go` (+9 -19) 📝 `hscontrol/mapper/tail_test.go` (+29 -10) 📝 `hscontrol/notifier/notifier.go` (+11 -10) 📝 `hscontrol/oidc.go` (+21 -35) 📝 `hscontrol/policy/acls_test.go` (+20 -18) 📝 `hscontrol/poll.go` (+10 -10) _...and 2 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:13 +01:00
adam closed this issue 2025-12-29 03:20:14 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2207