starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #737] [MERGED] Fixed another recurrence of MachineKey #1609

New Issue
Closed
opened 2025-12-29 02:30:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:30:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/737
Author: @juanfont
Created: 8/14/2022
Status: ✅ Merged
Merged: 8/14/2022
Merged by: @juanfont

Base: main ← Head: fix-machinekey-oidc

📝 Commits (3)

  • 5b14caf Fixed another recurrence of MachineKey
  • 90bb6ea Minor formatting changes
  • 7fb2f83 Merge branch 'main' into fix-machinekey-oidc

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 api.go (+7 -4)

📄 Description

Another fix for another occurrence of MachineKey being used as ID.

My bad, again. We really need some integration tests on the auth process. I will look at it after Noise.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/737 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 8/14/2022 **Status:** ✅ Merged **Merged:** 8/14/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-machinekey-oidc` --- ### 📝 Commits (3) - [`5b14caf`](https://github.com/juanfont/headscale/commit/5b14cafddd91bad3b0b9a5a454601f131b863d7e) Fixed another recurrence of MachineKey - [`90bb6ea`](https://github.com/juanfont/headscale/commit/90bb6ea907b74794dfdcf77edee3c7f23f6ea5de) Minor formatting changes - [`7fb2f83`](https://github.com/juanfont/headscale/commit/7fb2f8354036d0812ecbad485d51267624757243) Merge branch 'main' into fix-machinekey-oidc ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `api.go` (+7 -4) </details> ### 📄 Description Another fix for another occurrence of MachineKey being used as ID. My bad, again. We really need some integration tests on the auth process. I will look at it after Noise. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:55 +01:00
adam closed this issue 2025-12-29 02:30:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?