[PR #1566] [MERGED] Enhance pipeline stability and automatically retry unstable tests #2186

Closed
opened 2025-12-29 03:20:08 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1566
Author: @vsychov
Created: 9/28/2023
Status: Merged
Merged: 11/27/2023
Merged by: @kradalby

Base: mainHead: add-tests-retry


📝 Commits (2)

📊 Changes

40 files changed (+160 additions, -40 deletions)

View changed files

📝 .github/workflows/test-integration-v2-TestACLAllowStarDst.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLAllowUser80Dst.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLAllowUserDst.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLDenyAllPort80.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLDevice1CanAccessDevice2.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLHostsInNetMapTable.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLNamedHostsCanReach.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestACLNamedHostsCanReachBySubnet.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestApiKeyCommand.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestAuthKeyLogoutAndRelogin.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestAuthWebFlowAuthenticationPingAll.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestAuthWebFlowLogoutAndRelogin.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestCreateTailscale.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestDERPServerScenario.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestEnablingRoutes.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestEphemeral.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestExpireNode.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestHeadscale.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestNodeCommand.yaml (+4 -1)
📝 .github/workflows/test-integration-v2-TestNodeExpireCommand.yaml (+4 -1)

...and 20 more files

📄 Description

Hello there,

This Pull Request aims to introduce changes designed to enhance the overall stability of the pipeline and implement an automatic retry mechanism for tests that are currently unstable.

There is example, pipeline with retry: https://github.com/vsychov/headscale/pull/2
There is pipeline without retry: https://github.com/juanfont/headscale/pull/1562

Both of them contains same headscale file changes.

Another way to do that, is use --rerun-fails and --rerun-fails-max-failures arguments of gotestsum.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1566 **Author:** [@vsychov](https://github.com/vsychov) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 11/27/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `add-tests-retry` --- ### 📝 Commits (2) - [`cdda856`](https://github.com/juanfont/headscale/commit/cdda856568dd159f1c04f9882145898c8422e540) add test retry to action - [`06d2169`](https://github.com/juanfont/headscale/commit/06d2169462af8dc52b89f1afaa1335f0a0ff7a62) add test retry to action ### 📊 Changes **40 files changed** (+160 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration-v2-TestACLAllowStarDst.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLAllowUser80Dst.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLAllowUserDst.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLDenyAllPort80.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLDevice1CanAccessDevice2.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLHostsInNetMapTable.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLNamedHostsCanReach.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestACLNamedHostsCanReachBySubnet.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestApiKeyCommand.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestAuthKeyLogoutAndRelogin.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestAuthWebFlowAuthenticationPingAll.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestAuthWebFlowLogoutAndRelogin.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestCreateTailscale.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestDERPServerScenario.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestEnablingRoutes.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestEphemeral.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestExpireNode.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestHeadscale.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestNodeCommand.yaml` (+4 -1) 📝 `.github/workflows/test-integration-v2-TestNodeExpireCommand.yaml` (+4 -1) _...and 20 more files_ </details> ### 📄 Description Hello there, This Pull Request aims to introduce changes designed to enhance the overall stability of the pipeline and implement an automatic retry mechanism for tests that are currently unstable. There is example, pipeline with retry: https://github.com/vsychov/headscale/pull/2 There is pipeline without retry: https://github.com/juanfont/headscale/pull/1562 Both of them contains same headscale file changes. Another way to do that, is use `--rerun-fails` and `--rerun-fails-max-failures` arguments of `gotestsum`. - [x] read the [CONTRIBUTING guidelines](README.md#contributing) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:08 +01:00
adam closed this issue 2025-12-29 03:20:08 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2186