[PR #677] [MERGED] remove gin completely, ~2MB reduction on final binary #1566

Closed
opened 2025-12-29 02:30:36 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/677
Author: @huskyii
Created: 7/15/2022
Status: Merged
Merged: 7/20/2022
Merged by: @kradalby

Base: mainHead: remove_gin


📝 Commits (3)

  • aca5646 remove gin completely, ~2MB reduction on final binary
  • b755d47 update CHANGELOG
  • 5724f46 fix nix build

📊 Changes

5 files changed (+6 additions, -49 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 app.go (+4 -13)
📝 flake.nix (+1 -1)
📝 go.mod (+0 -11)
📝 go.sum (+0 -23)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/677 **Author:** [@huskyii](https://github.com/huskyii) **Created:** 7/15/2022 **Status:** ✅ Merged **Merged:** 7/20/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `remove_gin` --- ### 📝 Commits (3) - [`aca5646`](https://github.com/juanfont/headscale/commit/aca5646032da4bd3bfe163766926ce170c48815e) remove gin completely, ~2MB reduction on final binary - [`b755d47`](https://github.com/juanfont/headscale/commit/b755d4765258027584b505e03a606f65380ada82) update CHANGELOG - [`5724f46`](https://github.com/juanfont/headscale/commit/5724f4607c0bc24ccb6ceca2e84870eed63f7d0e) fix nix build ### 📊 Changes **5 files changed** (+6 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `app.go` (+4 -13) 📝 `flake.nix` (+1 -1) 📝 `go.mod` (+0 -11) 📝 `go.sum` (+0 -23) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:30:36 +01:00
adam closed this issue 2025-12-29 02:30:36 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1566