starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1046] [MERGED] Do not explicitly set the protocols when omitted in ACL #1838

New Issue
Closed
opened 2025-12-29 02:31:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1046
Author: @juanfont
Created: 12/5/2022
Status: ✅ Merged
Merged: 12/5/2022
Merged by: @juanfont

Base: main ← Head: minor-wildcard-protocol

📝 Commits (1)

  • fc75d1d Do not explicitly set the protocols when ommited in ACL

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 acls.go (+1 -6)

📄 Description

As per tailcfg.FilterRule, when the protocol of an ACL is omitted it "means TCP, UDP, and ICMP" - but to the client it is sent nil. It is up to the client to apply that special case.

The PR adheres Headscale to the behaviour of the SaaS

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1046 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 12/5/2022 **Status:** ✅ Merged **Merged:** 12/5/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `minor-wildcard-protocol` --- ### 📝 Commits (1) - [`fc75d1d`](https://github.com/juanfont/headscale/commit/fc75d1d8d08894ca846e038c3d7a9b90f0a35f65) Do not explicitly set the protocols when ommited in ACL ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `acls.go` (+1 -6) </details> ### 📄 Description As per `tailcfg.FilterRule`, when the protocol of an ACL is omitted it "means TCP, UDP, and ICMP" - but to the client it is sent nil. It is up to the client to apply that special case. The PR adheres Headscale to the behaviour of the SaaS --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:54 +01:00
adam closed this issue 2025-12-29 02:31:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?