starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-04-11 11:37:03 +02:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

db: fix slice aliasing in migration tag merge

Browse Source 
The migration at db.go:680 appends validated tags to existing tags
using append(existingTags, validatedTags...) where existingTags
aliases node.Tags. When node.Tags has spare capacity, append writes
into the shared backing array, and the subsequent slices.Sort
corrupts the original.

Clone existingTags before appending to prevent aliasing.
This commit is contained in:
Kristoffer Dalby
2026-04-08 12:25:21 +00:00
committed by Kristoffer Dalby
parent 82bb4331f5
commit 3037e5eee0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hscontrol/db/db.go
View File

@@ -677,7 +677,7 @@ AND auth_key_id NOT IN (
continue
}
mergedTags := append(existingTags, validatedTags...)
mergedTags := append(slices.Clone(existingTags), validatedTags...)
slices.Sort(mergedTags)
mergedTags = slices.Compact(mergedTags)