starred/deltaglider
1
0
Fork 0
mirror of https://github.com/beshu-tech/deltaglider.git synced 2026-01-11 22:30:48 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

fix: Correct logging message formatting in get_bucket_stats and update test assertionsalls for clarity.

Browse Source
This commit is contained in:
Simone Scarduzio
2025-10-11 14:05:54 +02:00
parent 35d34d4862
commit f75db142e8
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/deltaglider/client_operations/stats.py
View File

@@ -256,7 +256,7 @@ def get_bucket_stats(
path = f"{deltaspace}/reference.bin" if deltaspace else "reference.bin"
client.service.logger.warning(f" - s3://{bucket}/{path} ({size:,} bytes)")
client.service.logger.warning(f"\nConsider removing these orphaned files:\n")
client.service.logger.warning("\nConsider removing these orphaned files:\n")
for deltaspace in reference_files:
path = f"{deltaspace}/reference.bin" if deltaspace else "reference.bin"
client.service.logger.warning(f" aws s3 rm s3://{bucket}/{path}")

12
tests/unit/test_stats_algorithm.py
View File

@@ -1,10 +1,10 @@
"""Exhaustive tests for the bucket statistics algorithm."""
from unittest.mock import MagicMock, Mock, patch
import pytest
from unittest.mock import Mock, MagicMock, patch, call
from deltaglider.client_operations.stats import get_bucket_stats
from deltaglider.client_models import BucketStats
from deltaglider.core.models import ObjectHead
class TestBucketStatsAlgorithm:
@@ -353,7 +353,7 @@ class TestBucketStatsAlgorithm:
)
with patch_as_completed:
stats = get_bucket_stats(mock_client, "parallel-bucket")
_ = get_bucket_stats(mock_client, "parallel-bucket")
# Verify ThreadPoolExecutor was used with correct max_workers
mock_executor.assert_called_once_with(max_workers=10) # min(10, 50) = 10
@@ -371,7 +371,7 @@ class TestBucketStatsAlgorithm:
# Test with detailed_stats=False (default)
with patch("deltaglider.client_operations.stats.concurrent.futures"):
stats = get_bucket_stats(mock_client, "test-bucket", detailed_stats=False)
_ = get_bucket_stats(mock_client, "test-bucket", detailed_stats=False)
# Should NOT fetch metadata
mock_client.service.storage.head.assert_not_called()
@@ -383,7 +383,7 @@ class TestBucketStatsAlgorithm:
mock_client.service.storage.head.return_value = Mock(metadata={"file_size": "19500000"})
with patch("deltaglider.client_operations.stats.concurrent.futures"):
stats = get_bucket_stats(mock_client, "test-bucket", detailed_stats=True)
_ = get_bucket_stats(mock_client, "test-bucket", detailed_stats=True)
# Should fetch metadata
assert mock_client.service.storage.head.called